-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Massive web cleanup. #790
Open
dbrewster
wants to merge
31
commits into
main
Choose a base branch
from
dlb/web-cleanup
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+18,794
−14,365
Open
Massive web cleanup. #790
Changes from 21 commits
Commits
Show all changes
31 commits
Select commit
Hold shift + click to select a range
e75db3c
Massive web cleanup.
dbrewster b3d95f9
Hope this work
dbrewster 24e726e
Alrightly then
dbrewster e8ab8be
Better be on the safe side
dbrewster 8f1845b
Fix lint errors
dbrewster 017bb76
Upgrade turbo
dbrewster c8a709b
Upgrade lint. Fix lint errors
dbrewster 9aa7e0b
More UI changes.
dbrewster 908ce74
More changes to clean up the UI
dbrewster 0958dd5
updating lock
dbrewster 88c7594
Fixed nested conversations
dbrewster ea4baac
Removed print statement
dbrewster 75f9461
Added header icons
dbrewster 43752f7
Cleaned up description.
dbrewster 3c469da
Fixed some issues
dbrewster d4a4213
More fixes to layout and style
dbrewster 38b7e17
Removed console.log statements
dbrewster bba6c99
Got tests to work
dbrewster 3bb10ac
Fix some tests
dbrewster 32b758c
Fix some tests
dbrewster 3fae2af
Merge remote-tracking branch 'origin/main' into dlb/web-cleanup
LukeLalor 2c0f2a2
Fix some tests
dbrewster d72e271
Fix some tests
dbrewster 379bc93
Turn off lint for some files
dbrewster 5a7fb30
Removed lookup for process -- not needed anymore.
dbrewster 1ce5d83
Fix bugs related to dev tool ui
dbrewster da6609e
Fix playwright tests
dbrewster 84f50ee
Make header show elipsis if header gets too small
dbrewster 43ac619
More DevTool Fixes
dbrewster d4431cf
update quickstart
LukeLalor 4619da4
Fixed links not showing up properly.
dbrewster File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
185 changes: 0 additions & 185 deletions
185
examples/eidolon_examples/venture_search_agent/api_logic_unit.py
This file was deleted.
Oops, something went wrong.
22 changes: 0 additions & 22 deletions
22
examples/eidolon_examples/venture_search_agent/generate_title.py
This file was deleted.
Oops, something went wrong.
63 changes: 0 additions & 63 deletions
63
examples/eidolon_examples/venture_search_agent/resources/CompanyFinder.yaml
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hidden becomes very ui specific. Perhaps it would be better to add a metadata object to any event, and then we can throw this in there?
If not, this shouldn't be Optional[bool], just make it a bool
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about "internal"? There are, and will likely be more of, events we don't want any UI to render, like this one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if that is the case, shouldn't we just put it in a separate context? maybe even a context with the name eidolon-hidden which the ui treats differently? seems like something we can represent without adding a new concept.