Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implement "outcome" property for transactions and spans #899

Merged
merged 11 commits into from
Aug 25, 2020
Merged

implement "outcome" property for transactions and spans #899

merged 11 commits into from
Aug 25, 2020

Conversation

beniwohli
Copy link
Contributor

This implements elastic/apm#299.

Additionally, the "status_code" attribute has been added to HTTP spans.

@beniwohli
implement "outcome" property for transactions and spans
e4a9827 
This implements elastic/apm#299.

Additionally, the "status_code" attribute has been added to HTTP spans.
@felixbarny felixbarny mentioned this pull request Aug 11, 2020
Merged
@apmmachine
Copy link
Contributor

apmmachine commented Aug 11, 2020 •
edited
Loading

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #899 updated]

  • Start Time: 2020-08-25T08:09:13.099+0000

  • Duration: 28 min 12 sec

Test stats 🧪

Test Results
Failed 0
Passed 10886
Skipped 7750
Total 18636

Steps errors

Expand to view the steps failures

  • Name: Shell Script

    • Description: ./tests/scripts/docker/run_tests.sh pypy-2 none

    • Duration: 4 min 33 sec

    • Start Time: 2020-08-25T08:16:17.850+0000

    • log

basepi
basepi reviewed Aug 11, 2020
View reviewed changes
Copy link
Contributor

@basepi basepi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good so far. One comment below.

elasticapm/traces.py Outdated Show resolved Hide resolved
felixbarny
felixbarny reviewed Aug 18, 2020
View reviewed changes
elasticapm/traces.py Outdated Show resolved Hide resolved
elasticapm/traces.py Outdated Show resolved Hide resolved
elasticapm/traces.py Outdated Show resolved Hide resolved
@beniwohli beniwohli marked this pull request as ready for review August 24, 2020 09:55
felixbarny
felixbarny approved these changes Aug 24, 2020
View reviewed changes
Copy link
Member

@felixbarny felixbarny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

The only thing I'd add is more docs around the semantics of the individual status values and how they affect error rate calculation. The spec PR has some details on that but having that on the API docs will make that more discoverable. Either add on the set_transaction_outcome docs or on the OUTCOME constants, plus on the API docs.

elasticapm/traces.py Show resolved Hide resolved
@basepi basepi mentioned this pull request Aug 24, 2020
Merged
8 tasks
@beniwohli beniwohli mentioned this pull request Aug 25, 2020
Merged
7 tasks
@beniwohli
Copy link
Contributor Author

@felixbarny does 0124d6873 address your comment on documentation?

@felixbarny
Copy link
Member

It does!

@beniwohli
Copy link
Contributor Author

@basepi I saw you added a new "unreleased" changelog section in #898. I'll skip that here to avoid merge conflicts. I'll add the entry when you merged the httpx PR

@beniwohli beniwohli merged commit cb78017 into elastic:master Aug 25, 2020
@beniwohli beniwohli deleted the transaction-outcome branch August 25, 2020 09:48
@felixbarny felixbarny added this to the 7.10 milestone Aug 25, 2020
basepi added a commit to basepi/apm-agent-python that referenced this pull request Aug 25, 2020
@basepi
Add changelog for elastic#899
c4385e6
basepi added a commit that referenced this pull request Aug 25, 2020
@basepi @HenrikOssipoff
Add instrumentation for httpx and httpcore (#898)
ccf656f 
* Add instrumentation for httpx

* Add instrumentation for httpx.Client and httpx.AsyncClient

* Add to changelog

* Add link to PR in changelog

* Update link in changelog

* Add 0.12 to the jenkins_framework_full

* Add some initial tests (based on requests tests)

* Rename session test

* Add httpcore sync and async instrumentations

* Test fixes for httpx

* Add async httpx tests

* Add httpx.sh to properly set the pytest marker

* Remove some copy pasta

* Add review fixes

* Add outcome to httpx spans

* Add changelog for #899

Co-authored-by: HenrikOssipoff <henrik.ossipoff@gmail.com>
@SylvainJuge SylvainJuge mentioned this pull request Oct 8, 2020
Closed
romulorosa pushed a commit to romulorosa/apm-agent-python that referenced this pull request Oct 15, 2020
@beniwohli @romulorosa
implement "outcome" property for transactions and spans (elastic#899)
c75b834
romulorosa pushed a commit to romulorosa/apm-agent-python that referenced this pull request Oct 15, 2020
@basepi @HenrikOssipoff @romulorosa
Add instrumentation for httpx and httpcore (elastic#898)
ca6a014 
* Add instrumentation for httpx

* Add instrumentation for httpx.Client and httpx.AsyncClient

* Add to changelog

* Add link to PR in changelog

* Update link in changelog

* Add 0.12 to the jenkins_framework_full

* Add some initial tests (based on requests tests)

* Rename session test

* Add httpcore sync and async instrumentations

* Test fixes for httpx

* Add async httpx tests

* Add httpx.sh to properly set the pytest marker

* Remove some copy pasta

* Add review fixes

* Add outcome to httpx spans

* Add changelog for elastic#899

Co-authored-by: HenrikOssipoff <henrik.ossipoff@gmail.com>
romulorosa pushed a commit to romulorosa/apm-agent-python that referenced this pull request Oct 15, 2020
@beniwohli @romulorosa
implement "outcome" property for transactions and spans (elastic#899)
730ab95
romulorosa pushed a commit to romulorosa/apm-agent-python that referenced this pull request Oct 15, 2020
@basepi @HenrikOssipoff @romulorosa
Add instrumentation for httpx and httpcore (elastic#898)
c4b571c 
* Add instrumentation for httpx

* Add instrumentation for httpx.Client and httpx.AsyncClient

* Add to changelog

* Add link to PR in changelog

* Update link in changelog

* Add 0.12 to the jenkins_framework_full

* Add some initial tests (based on requests tests)

* Rename session test

* Add httpcore sync and async instrumentations

* Test fixes for httpx

* Add async httpx tests

* Add httpx.sh to properly set the pytest marker

* Remove some copy pasta

* Add review fixes

* Add outcome to httpx spans

* Add changelog for elastic#899

Co-authored-by: HenrikOssipoff <henrik.ossipoff@gmail.com>
beniwohli added a commit to beniwohli/apm-agent-python that referenced this pull request Sep 14, 2021
@beniwohli
implement "outcome" property for transactions and spans (elastic#899)
646ce92
beniwohli pushed a commit to beniwohli/apm-agent-python that referenced this pull request Sep 14, 2021
@basepi @HenrikOssipoff @beniwohli
Add instrumentation for httpx and httpcore (elastic#898)
cda8ac3 
* Add instrumentation for httpx

* Add instrumentation for httpx.Client and httpx.AsyncClient

* Add to changelog

* Add link to PR in changelog

* Update link in changelog

* Add 0.12 to the jenkins_framework_full

* Add some initial tests (based on requests tests)

* Rename session test

* Add httpcore sync and async instrumentations

* Test fixes for httpx

* Add async httpx tests

* Add httpx.sh to properly set the pytest marker

* Remove some copy pasta

* Add review fixes

* Add outcome to httpx spans

* Add changelog for elastic#899

Co-authored-by: HenrikOssipoff <henrik.ossipoff@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@basepi basepi basepi approved these changes

@felixbarny felixbarny felixbarny approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
7.10
Development

Successfully merging this pull request may close these issues.
4 participants
@beniwohli @apmmachine @felixbarny @basepi