Add event.outcome to transactions and spans #4064
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💔 Build Failed
Expand to view the summary
Build stats
Steps errorsExpand to view the steps failures
Log outputExpand to view the last 100 lines of log output
|
axw
force-pushed
the
event-outcome
branch
3 times, most recently
from
21be456
to
318f9cf
Compare
jalvz
reviewed
Aug 11, 2020
axw
force-pushed
the
event-outcome
branch
3 times, most recently
from
e3fcb7b
to
a4abbb2
Compare
axw
force-pushed
the
event-outcome
branch
7 times, most recently
from
3219c30
to
50aca18
Compare
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Steps errorsExpand to view the steps failures
|
|
Note to reviewer: you might want to filter out the |
simitt
approved these changes
Aug 25, 2020
|
An agent implementation can be found here: elastic/apm-agent-python#899 |
|
Thanks @beniwohli. I tested with apm-agent-python & aiohttp, and it appears to be working well:
|
jalvz
pushed a commit
to jalvz/apm-server
that referenced
this pull request
Aug 31, 2020
* spec: add {transaction,span}.outcome
* model: add {Span,Transaction}.Outcome fields
* model/modeldecoder: {span,transaction}.outcome
* Update fields, tests, generated docs
* Add changelog entry
jalvz
added a commit
that referenced
this pull request
Sep 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation/summary
This PR adds
outcomeas a field oftransactionandspan. For RUM v3,outcomeis abbreviated too.The value will be recorded as the
event.outcomein the event documents, and will be used for calculating error rates.Checklist
I have considered changes for:
- [ ] logging (add log lines, choose appropriate log selector, etc.)- [ ] metrics and monitoring (create issue for Kibana team to add metrics to visualizations, e.g. Kibana#44001)- [ ] telemetryHow to test these changes
Cannot be manually tested until we have a modified agent.
Related issues
elastic/apm#299