[Heartbeat] Merge synthetic root fields into events #24770
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes elastic#24768 This allows synthetics to drive more field names without requiring heartbeat updates. Any fields in `root_fields` get merged into the event root.
andrewvc
added
enhancement
Heartbeat
Team:obs-ds-hosted-services
|
Pinging @elastic/uptime (Team:Uptime) |
botelastic
bot
added
needs_team
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪💚 Flaky test reportTests succeeded. Expand to view the summary
Test stats 🧪
|
andrewvc
added a commit
to andrewvc/beats
that referenced
this pull request
Mar 30, 2021
Fixes elastic#24768 This allows synthetics to drive more field names without requiring heartbeat updates. Any fields in root_fields get merged into the event root. This also improves the testing in this area of the code, which was somewhat lean (and really was only tested in larger functional tests run elsewhere)
andrewvc
added a commit
that referenced
this pull request
Mar 30, 2021
Fixes #24768 This allows synthetics to drive more field names without requiring heartbeat updates. Any fields in root_fields get merged into the event root. This also improves the testing in this area of the code, which was somewhat lean (and really was only tested in larger functional tests run elsewhere)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #24768
This allows synthetics to drive more field names without requiring heartbeat updates. Any fields in
root_fieldsget merged into the event root.This also improves the testing in this area of the code, which was somewhat lean (and really was only tested in larger functional tests run elsewhere)
Why is it important?
Without this any field change must be made in two places (synthetics and here), this simplifies our arch.
Checklist
CHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Author's Checklist