Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Heartbeat] Root fields for synthetics #24768

Closed
andrewvc opened this issue Mar 25, 2021 · 2 comments · Fixed by #24770
Closed

[Heartbeat] Root fields for synthetics #24768

andrewvc opened this issue Mar 25, 2021 · 2 comments · Fixed by #24770
Assignees
@justinkambic
Labels
enhancement Heartbeat Team:obs-ds-hosted-services Label for the Observability Hosted Services team test-plan-ok This PR passed manual testing v7.13.0

Comments

@andrewvc
Copy link
Contributor

We need to interpolate the new root_fields field from synthetics into the base of events per elastic/synthetics#215

This just means looking for that field and merging it in.
@andrewvc andrewvc added enhancement Heartbeat Team:obs-ds-hosted-services Label for the Observability Hosted Services team v7.13.0 labels Mar 25, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/uptime (Team:Uptime)

andrewvc added a commit to andrewvc/beats that referenced this issue Mar 25, 2021
@andrewvc
[Heartbeat] Merge synthetic root fields into events
6fb1d2b 
Fixes elastic#24768

This allows synthetics to drive more field names without requiring
heartbeat updates. Any fields in `root_fields` get merged into the event
root.
@andrewvc andrewvc mentioned this issue Mar 25, 2021
Merged
7 tasks
andrewvc added a commit that referenced this issue Mar 30, 2021
@andrewvc
[Heartbeat] Merge synthetic root fields into events (#24770)
2b00b83 
Fixes #24768

This allows synthetics to drive more field names without requiring heartbeat updates. Any fields in root_fields get merged into the event root.

This also improves the testing in this area of the code, which was somewhat lean (and really was only tested in larger functional tests run elsewhere)
andrewvc added a commit to andrewvc/beats that referenced this issue Mar 30, 2021
@andrewvc
[Heartbeat] Merge synthetic root fields into events (elastic#24770)
a1f9860 
Fixes elastic#24768

This allows synthetics to drive more field names without requiring heartbeat updates. Any fields in root_fields get merged into the event root.

This also improves the testing in this area of the code, which was somewhat lean (and really was only tested in larger functional tests run elsewhere)
andrewvc added a commit that referenced this issue Mar 30, 2021
@andrewvc
[Heartbeat] Merge synthetic root fields into events (#24770) (#24860)
c812dd6 
Fixes #24768

This allows synthetics to drive more field names without requiring heartbeat updates. Any fields in root_fields get merged into the event root.

This also improves the testing in this area of the code, which was somewhat lean (and really was only tested in larger functional tests run elsewhere)
@justinkambic justinkambic self-assigned this May 4, 2021
@justinkambic
Copy link
Contributor

When running 7.13 stack, I was able to query for the fields that are specified as root fields in the synthetics PR that introduced these root_fields.

image

@justinkambic justinkambic added the test-plan-ok This PR passed manual testing label May 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@justinkambic justinkambic

Labels
enhancement Heartbeat Team:obs-ds-hosted-services Label for the Observability Hosted Services team test-plan-ok This PR passed manual testing v7.13.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Heartbeat] Merge synthetic root fields into events andrewvc/beats
4 participants
@andrewvc @elasticmachine @justinkambic @paulb-elastic