Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: move fields to ECS format #215

Merged
merged 4 commits into from
Feb 10, 2021
Merged

feat: move fields to ECS format #215

merged 4 commits into from
Feb 10, 2021

Conversation

vigneshshanmugam
Copy link
Member

@apmmachine
Copy link

apmmachine commented Feb 4, 2021 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #215 updated

  • Start Time: 2021-02-10T01:18:38.296+0000

  • Duration: 17 min 49 sec

  • Commit: 2d7a8e6

Test stats 🧪

Test Results
Failed 0
Passed 60
Skipped 7
Total 67

Trends 🧪

Image of Build Times

Image of Tests

vigneshshanmugam
vigneshshanmugam commented Feb 5, 2021
View reviewed changes
src/plugins/network.ts
/**
* Enhance request headers with additional information
*/
record.request.headers = {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is done here instead of on response as response event can sometimes be not fired for dropped requests, so moved it before. Also this lets us do our next iteration in our waterfall which is Add flyout in waterfall

andrewvc
andrewvc reviewed Feb 5, 2021
View reviewed changes
Copy link
Contributor

@andrewvc andrewvc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good, left some notes on areas where it could be improved

__tests__/reporters/json.test.ts Show resolved Hide resolved
src/reporters/json.ts Outdated Show resolved Hide resolved
src/reporters/json.ts Outdated Show resolved Hide resolved
src/reporters/json.ts Show resolved Hide resolved
src/reporters/json.ts Outdated Show resolved Hide resolved
src/reporters/json.ts Outdated Show resolved Hide resolved
andrewvc
andrewvc approved these changes Feb 9, 2021
View reviewed changes
Copy link
Contributor

@andrewvc andrewvc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending the UA change

@vigneshshanmugam vigneshshanmugam merged commit 7101ad7 into elastic:master Feb 10, 2021
@vigneshshanmugam vigneshshanmugam deleted the ecs-format branch February 10, 2021 01:36
@andrewvc andrewvc mentioned this pull request Mar 25, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewvc andrewvc andrewvc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move network fields to ECS where possible (starting with network data)
3 participants
@vigneshshanmugam @apmmachine @andrewvc