Update agent managed manifest to include enrolment token variable #26756
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaelKatsoulis
added
enhancement
Team:Integrations
|
Pinging @elastic/integrations (Team:Integrations) |
botelastic
bot
added
needs_team
💚 Build Succeeded
Expand to view the summary
Build stats
Trends 🧪❕ Flaky test reportNo test was executed to be analysed. |
ChrsMark
reviewed
Jul 7, 2021
| # The ip:port pair of fleet server | ||
| - name: FLEET_URL | ||
| value: "https://fleet-server:8220" | ||
| # If left empty KIBANA_HOST, KIBANA_FLEET_USERNAME, KIBANA_FLEET_PASSWORD are needed | ||
| - name: FLEET_ENROLLMENT_TOKEN | ||
| value: "token" |
There was a problem hiding this comment.
Why not leaving this empty by default?
There was a problem hiding this comment.
Ok. Let's go with default values.
| @@ -28,10 +28,13 @@ spec: | |||
| value: "1" | |||
| # Set to true in case of insecure or unverified HTTP | |||
| - name: FLEET_INSECURE | |||
| value: false | |||
| value: "false" | |||
There was a problem hiding this comment.
Maybe setting this as true by default is better as the base case?
There was a problem hiding this comment.
Ok I don't have a strong argument on that.
ChrsMark
approved these changes
Jul 7, 2021
MichaelKatsoulis
added a commit
that referenced
this pull request
Jul 8, 2021
v1v
added a commit
to v1v/beats
that referenced
this pull request
Jul 8, 2021
* upstream/master: (430 commits) CI: increase timeout (elastic#26764) Heartbeat: add datastream fields to synthetics (elastic#26774) Osquerybeat: Change the query timeout from 3 secs to 60 secs (elastic#26775) Remove experimental warning for inputs with variables. (elastic#26762) Add latest k8s versions in testing (elastic#26729) change type of max_bytes to ByteType (elastic#26699) [Elastic Agent] Fix broken enrollment command (elastic#26749) Update agent managed manifest to include enrolment token variable (elastic#26756) Filebeat: Ensure module pipelines compatibility with previous versions of Elasticsearch (elastic#26737) Forward port changelog for 7.13.3 (elastic#26731) to master (elastic#26754) Upgrade PyYAML dependency used for tests (elastic#26746) Add agent fleet enrolment k8s manifest (elastic#26566) CI: retry the step only (elastic#26736) Osquerybeat: Fix the configuration poll interval setting (elastic#26739) [Filebeat] Replace copy_from with templated value (elastic#26631) Reduce the verbosity of the debug log for monitoring (elastic#26583) Add instructions on testing metricbeat kubernetes module (elastic#26643) Revert "[CI] fight the flakiness with some retry option in the CI only for the Pull Requests (elastic#26617)" (elastic#26704) Packaging: linux/armv7 is not supported (elastic#26706) Cyberarkpas: Link to official docs on how to setup TLS (elastic#26614) ...
This was referenced Jul 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds FLEET_ENROLLMENT_TOKEN in managed elastic-agent manifest.
Why is it important?
Agent can enrol to fleet server policy either by specifying an enrolment token for a specific policy or by
connecting to Kibana and getting the default one.
Checklist
CHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.