Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Osquerybeat: Change the query timeout from 3 secs to 60 secs #26775

Merged
merged 1 commit into from
Jul 7, 2021
Merged

Osquerybeat: Change the query timeout from 3 secs to 60 secs #26775

merged 1 commit into from
Jul 7, 2021

Conversation

aleksmaus
Copy link
Member

What does this PR do?

Increase osquery timeout from 3 secs to 60 secs. The 3 seconds timeout was too low for wifi_survey table query for example which was taking more like 5 seconds on the test box if running standalone with osqueryi. Bumping the value up eliminated timeouts.

Why is it important?

Some queries will timeout on slower machines, 3 secs timeout was not enough.

image

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas

Related issues

Screenshots

Validated the wifi_survey table query completes successfully after the change:
Screen Shot 2021-07-07 at 2 12 03 PM

@aleksmaus
Osquerybeat: Change the query timeout from 3 secs to 60 secs
228d5c1 
* The 3 seconds timeout was too low for wifi_survey query for example
  which was taking more like 5 seconds on the test box. Bumping the
  value up eliminited timeouts.
@aleksmaus aleksmaus added bug backport-v7.14.0 Automated backport with mergify Team:Asset Mgt backport-v7.15.0 Automated backport with mergify labels Jul 7, 2021
@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Jul 7, 2021
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2021-07-07T20:34:37.616+0000

  • Duration: 51 min 27 sec

  • Commit: 228d5c1

Test stats 🧪

Test Results
Failed 0
Passed 136
Skipped 0
Total 136

Trends 🧪

Image of Build Times

Image of Tests

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 136
Skipped 0
Total 136

@aleksmaus aleksmaus merged commit 1754f54 into elastic:master Jul 7, 2021
@aleksmaus aleksmaus deleted the change/osquery_timeout branch July 7, 2021 21:27
mergify bot pushed a commit that referenced this pull request Jul 7, 2021
@aleksmaus
Osquerybeat: Change the query timeout from 3 secs to 60 secs (#26775)
4dfa164 
* The 3 seconds timeout was too low for wifi_survey query for example
  which was taking more like 5 seconds on the test box. Bumping the
  value up eliminited timeouts.

(cherry picked from commit 1754f54)
@mergify mergify bot mentioned this pull request Jul 7, 2021
Merged
mergify bot pushed a commit that referenced this pull request Jul 7, 2021
@aleksmaus
Osquerybeat: Change the query timeout from 3 secs to 60 secs (#26775)
f7a4c3a 
* The 3 seconds timeout was too low for wifi_survey query for example
  which was taking more like 5 seconds on the test box. Bumping the
  value up eliminited timeouts.

(cherry picked from commit 1754f54)
@mergify mergify bot mentioned this pull request Jul 7, 2021
Merged
aleksmaus added a commit that referenced this pull request Jul 7, 2021
@mergify @aleksmaus
Osquerybeat: Change the query timeout from 3 secs to 60 secs (#26775) (…
8888cbe 
…#26778)

* The 3 seconds timeout was too low for wifi_survey query for example
  which was taking more like 5 seconds on the test box. Bumping the
  value up eliminited timeouts.

(cherry picked from commit 1754f54)

Co-authored-by: Aleksandr Maus <aleksandr.maus@elastic.co>
aleksmaus added a commit that referenced this pull request Jul 7, 2021
@mergify @aleksmaus
Osquerybeat: Change the query timeout from 3 secs to 60 secs (#26775) (…
cadf89b 
…#26779)

* The 3 seconds timeout was too low for wifi_survey query for example
  which was taking more like 5 seconds on the test box. Bumping the
  value up eliminited timeouts.

(cherry picked from commit 1754f54)

Co-authored-by: Aleksandr Maus <aleksandr.maus@elastic.co>
v1v added a commit to v1v/beats that referenced this pull request Jul 8, 2021
@v1v
Merge remote-tracking branch 'upstream/master' into feature/use-debian-9
1d835f9 
* upstream/master: (430 commits)
  CI: increase timeout (elastic#26764)
  Heartbeat: add datastream fields to synthetics (elastic#26774)
  Osquerybeat: Change the query timeout from 3 secs to 60 secs (elastic#26775)
  Remove experimental warning for inputs with variables. (elastic#26762)
  Add latest k8s versions in testing (elastic#26729)
  change type of max_bytes to ByteType (elastic#26699)
  [Elastic Agent] Fix broken enrollment command (elastic#26749)
  Update agent managed manifest to include enrolment token variable (elastic#26756)
  Filebeat: Ensure module pipelines compatibility with previous versions of Elasticsearch (elastic#26737)
  Forward port changelog for 7.13.3 (elastic#26731) to master (elastic#26754)
  Upgrade PyYAML dependency used for tests (elastic#26746)
  Add agent fleet enrolment k8s manifest (elastic#26566)
  CI: retry the step only (elastic#26736)
  Osquerybeat: Fix the configuration poll interval setting (elastic#26739)
  [Filebeat] Replace copy_from with templated value (elastic#26631)
  Reduce the verbosity of the debug log for monitoring (elastic#26583)
  Add instructions on testing metricbeat kubernetes module (elastic#26643)
  Revert "[CI] fight the flakiness with some retry option in the CI only for the Pull Requests (elastic#26617)" (elastic#26704)
  Packaging: linux/armv7 is not supported (elastic#26706)
  Cyberarkpas: Link to official docs on how to setup TLS (elastic#26614)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@james-elastic james-elastic james-elastic approved these changes

@scunningham scunningham Awaiting requested review from scunningham

Assignees
No one assigned
Labels
backport-v7.14.0 Automated backport with mergify backport-v7.15.0 Automated backport with mergify bug Team:Asset Mgt
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aleksmaus @elasticmachine @james-elastic