Filebeat: Change compatibility test stage to test against previous minor instead of 7.11 #28274

adriansr · 2021-10-06T09:53:28Z

What does this PR do?

This changes the compatibility test for Filebeat modules to test with the previous released minor.

Why is it important?

To ensure backwards compatibility with the latest supported version

Related issues

Relates [Filebeat] Module incompatibility with older ES/Kibana versions #26629

This changes the compatibility test for Filebeat modules to test with the previous released minor. Relates elastic#26629

elasticmachine · 2021-10-06T09:53:30Z

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

mergify · 2021-10-06T09:54:21Z

This pull request does not have a backport label. Could you fix it @adriansr? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

backport-v./d./d./d is the label to automatically backport to the 7./d branch. /d is the digit

NOTE: backport-skip has been added to this pull request.

elasticmachine · 2021-10-06T11:05:49Z

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS

Expand to view the summary

Build stats

Start Time: 2021-10-06T17:38:30.172+0000
Duration: 159 min 13 sec
Commit: f0e3d5b

Test stats 🧪

Test	Results
Failed	0
Passed	53653
Skipped	5346
Total	58999

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

/test : Re-trigger the build.
/package : Generate the packages and run the E2E tests.
/beats-tester : Run the installation tests with beats-tester.

andrewkroh · 2021-10-06T14:09:42Z

testing/environments/prev-minor.yml

+  kibana:
+    image: docker.elastic.co/kibana/kibana:7.15.0
+    healthcheck:
+      test: ["CMD-SHELL", "curl -s http://localhost:5601/api/status | grep -q 'Looking good'"]


"Looking good" isn't so good anymore because the status format will change in 7.16. I recommend

beats/testing/environments/snapshot.yml

Line 39 in 3c1731d

test: ["CMD-SHELL", "curl -s http://localhost:5601/api/status?v8format=true | grep -q '\"overall\":{\"level\":\"available\"'"]

done, also fixed snapshot-oss.yml

andrewkroh

LGTM

andrewkroh · 2021-10-06T17:59:33Z

So for master, once 7.16.0 is released this will change to that?

And for the 7.x (and 7.16) branch, this will remain as 7.15.0?

adriansr · 2021-10-06T20:57:22Z

@andrewkroh, yes, this file will be automatically updated by the release scripts (that's a work in progress)

…nor instead of 7.11 (#28274) This changes the compatibility test for Filebeat modules to test with the previous released minor. Relates #26629 (cherry picked from commit 9806f91)

…nor instead of 7.11 (#28274) This changes the compatibility test for Filebeat modules to test with the previous released minor. Relates #26629 (cherry picked from commit 9806f91) # Conflicts: # filebeat/Jenkinsfile.yml # testing/environments/prev-minor.yml # x-pack/filebeat/Jenkinsfile.yml

…nor instead of 7.11 (#28274) (#28307) This changes the compatibility test for Filebeat modules to test with the previous released minor. Relates #26629 (cherry picked from commit 9806f91) Co-authored-by: Adrian Serrano <adrisr83@gmail.com>

* upstream/master: (73 commits) Remove GCP support from Functionbeat (elastic#28253) Move labels and annotations under kubernetes.namespace. (elastic#27917) Update go release version 1.17.1 (elastic#27543) Osquerybeat: Runner and Fetcher unit tests (elastic#28290) Osquerybeat: Improve handling of osquery.autoload file, allow customizations (elastic#28289) seccomp: allow clone3 syscall for x86 (elastic#28117) packetbeat/protos/dns: don't render missing A and AAAA addresses from truncated records (elastic#28297) [7.x] [DOCS] Update api_key example on elasticsearch output (elastic#28288) [cloud][docker] use the private docker namespace (elastic#28286) Update aws-lambda-go library version to 1.13.3 (elastic#28236) Deprecate common.Float (elastic#28280) Filebeat: Change compatibility test stage to test against previous minor instead of 7.11 (elastic#28274) x-pack/filebeat/module/threatintel/misp: add support for secondary object attribute handling (elastic#28124) Explicitly pass http config to doppler consumer (elastic#28277) processors/actions/add_fields: Do not panic if event.Fields is nil map (elastic#28219) Resolved timestamp for defender atp (elastic#28272) [Winlogbeat] Tolerate faults when Windows Event Log session is interrupted (elastic#28191) [elastic-agent] proxy requests to subprocesses to their metrics endpoints (elastic#28165) Build cloud docker images for elastic-agent (elastic#28134) Upgrade k8s go-client library (elastic#28228) ...

…nor instead of 7.11 (elastic#28274) This changes the compatibility test for Filebeat modules to test with the previous released minor. Relates elastic#26629

In elastic#26629 the issue around running Filebeat against older version of Elasticsearch was discussed and in elastic#28274 testing against the previous minor was introduced. But since 8.0, Filebeat can only ship data to equal or newer versions of Elasticsearch. Because of this, in the tests `TESTING_FILEBEAT_ALLOW_OLDER=1` had to be introduced. I'm opening this PR to remove this testing as it is not something we support anymore.

In #26629 the issue around running Filebeat against older version of Elasticsearch was discussed and in #28274 testing against the previous minor was introduced. But since 8.0, Filebeat can only ship data to equal or newer versions of Elasticsearch. Because of this, in the tests `TESTING_FILEBEAT_ALLOW_OLDER=1` had to be introduced. I'm opening this PR to remove this testing as it is not something we support anymore.

In elastic#26629 the issue around running Filebeat against older version of Elasticsearch was discussed and in elastic#28274 testing against the previous minor was introduced. But since 8.0, Filebeat can only ship data to equal or newer versions of Elasticsearch. Because of this, in the tests `TESTING_FILEBEAT_ALLOW_OLDER=1` had to be introduced. I'm opening this PR to remove this testing as it is not something we support anymore.

In #26629 the issue around running Filebeat against older version of Elasticsearch was discussed and in #28274 testing against the previous minor was introduced. But since 8.0, Filebeat can only ship data to equal or newer versions of Elasticsearch. Because of this, in the tests `TESTING_FILEBEAT_ALLOW_OLDER=1` had to be introduced. I'm opening this PR to remove this testing as it is not something we support anymore.

Change 7.11-compat test to prev-minor test

7f93c36

This changes the compatibility test for Filebeat modules to test with the previous released minor. Relates elastic#26629

adriansr added review :Testing ci Team:Security-External Integrations labels Oct 6, 2021

botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Oct 6, 2021

mergify bot added the backport-skip Skip notification from the automated backport with mergify label Oct 6, 2021

Fix

8b8e35b

andrewkroh reviewed Oct 6, 2021

View reviewed changes

adriansr changed the title ~~Filebeat: Change compatibility test stage to test against previos minor instead of 7.11~~ Filebeat: Change compatibility test stage to test against previous minor instead of 7.11 Oct 6, 2021

Fix Kibana health check in testing environment

f0e3d5b

andrewkroh approved these changes Oct 6, 2021

View reviewed changes

adriansr added backport-v7.15.0 Automated backport with mergify backport-v7.16.0 Automated backport with mergify backport-v8.0.0 Automated backport with mergify labels Oct 7, 2021

mergify bot removed the backport-skip Skip notification from the automated backport with mergify label Oct 7, 2021

adriansr merged commit 9806f91 into elastic:master Oct 7, 2021

mergify bot mentioned this pull request Oct 7, 2021

[master](backport #28274) Filebeat: Change compatibility test stage to test against previous minor instead of 7.11 #28306

Closed

mergify bot mentioned this pull request Oct 7, 2021

[7.x](backport #28274) Filebeat: Change compatibility test stage to test against previous minor instead of 7.11 #28307

Merged

mergify bot mentioned this pull request Oct 7, 2021

[7.15](backport #28274) Filebeat: Change compatibility test stage to test against previous minor instead of 7.11 #28308

Closed

v1v mentioned this pull request Mar 16, 2022

[Release] Update test environments for 8.1.2 #30855

Merged

ruflin mentioned this pull request Mar 21, 2022

Remove prev-minor testing as not needed anymore #30926

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Filebeat: Change compatibility test stage to test against previous minor instead of 7.11 #28274

Filebeat: Change compatibility test stage to test against previous minor instead of 7.11 #28274

adriansr commented Oct 6, 2021

elasticmachine commented Oct 6, 2021

mergify bot commented Oct 6, 2021

elasticmachine commented Oct 6, 2021 •

edited by jenkins-beats-ci bot

Loading

Build stats

Test stats 🧪

andrewkroh Oct 6, 2021 •

edited

Loading

adriansr Oct 6, 2021

andrewkroh left a comment

andrewkroh commented Oct 6, 2021

adriansr commented Oct 6, 2021

Filebeat: Change compatibility test stage to test against previous minor instead of 7.11 #28274

Filebeat: Change compatibility test stage to test against previous minor instead of 7.11 #28274

Conversation

adriansr commented Oct 6, 2021

What does this PR do?

Why is it important?

Related issues

elasticmachine commented Oct 6, 2021

mergify bot commented Oct 6, 2021

elasticmachine commented Oct 6, 2021 • edited by jenkins-beats-ci bot Loading

💚 Build Succeeded

Build stats

Test stats 🧪

💚 Flaky test report

🤖 GitHub comments

andrewkroh Oct 6, 2021 • edited Loading

Choose a reason for hiding this comment

adriansr Oct 6, 2021

Choose a reason for hiding this comment

andrewkroh left a comment

Choose a reason for hiding this comment

andrewkroh commented Oct 6, 2021

adriansr commented Oct 6, 2021

elasticmachine commented Oct 6, 2021 •

edited by jenkins-beats-ci bot

Loading

andrewkroh Oct 6, 2021 •

edited

Loading