Skip to content
This repository has been archived by the owner on Sep 17, 2024. It is now read-only.

[Fleet] Add back test scenarios for .deb and .rpm systemd deploy syntax #379

Closed
EricDavisX opened this issue Oct 21, 2020 · 3 comments
Closed

[Fleet] Add back test scenarios for .deb and .rpm systemd deploy syntax #379

EricDavisX opened this issue Oct 21, 2020 · 3 comments
Labels
Team:Elastic-Agent Label for the Agent team

Comments

@EricDavisX
Copy link
Contributor

EricDavisX commented Oct 21, 2020 •
edited
Loading

In #378 we merged supported for the new 7.10 'install' subcommand. This changed the existing tests, which is ok (they were failing) but they were valid and needed tests.

The remaining tasks are

  1. to decide if we want to start a separate file for any remaining 'subcommands' as we had discussed here:
    [Fleet / Agent ] support install / uninstall command from Agent #326
  • tl;dr; the remaining ones are 'help' 'inspect' 'version' (and as of 7.10 'upgrade' and 'enroll' which was orphaned when we changed for the 'install' as noted above)
  1. to add in the .deb and .rpm syntax to the installer tests where desired, to maintain the coverage we had, using 'enroll' and 'run' subcommands as prior, which is still valid (tho is failing in recent builds and hopefully soon fixed).

the .deb/.rpm issue logged for Beats is:
elastic/beats#21200

after that, we encountered and have since fixed this as well that relates:
elastic/beats#22485
@EricDavisX EricDavisX added the Team:Elastic-Agent Label for the Agent team label Oct 21, 2020
This was referenced Oct 21, 2020
Closed
Merged
@EricDavisX EricDavisX mentioned this issue Nov 11, 2020
Merged
2 tasks
@EricDavisX EricDavisX mentioned this issue Nov 18, 2020
Merged
2 tasks
EricDavisX added a commit that referenced this issue Dec 2, 2020
@EricDavisX @mdelapenya
work for issue #379 - adding back rpm and deb tests (#439)
a30e1f4 
* adding back rpm and deb tests

* arbitrary change to trigger ci tests

* fix linting

* fixing more linting

* fully exploring gherkin linting apparently

* final linting fix

* updating ci suites to match new tags

* reset indention w feedback passes linting locally

* adding skip support and skipping rpm and deb tests

* back to fixing linting for tags now

Co-authored-by: Manuel de la Peña <mdelapenya@gmail.com>
EricDavisX added a commit that referenced this issue Dec 2, 2020
@EricDavisX
Revert "work for issue #379 - adding back rpm and deb tests (#439)"
09fbc41 
This reverts commit a30e1f4.
mdelapenya added a commit to mdelapenya/e2e-testing that referenced this issue Dec 2, 2020
@EricDavisX @mdelapenya
work for issue elastic#379 - adding back rpm and deb tests (elastic#439)
973953e 
* adding back rpm and deb tests

* arbitrary change to trigger ci tests

* fix linting

* fixing more linting

* fully exploring gherkin linting apparently

* final linting fix

* updating ci suites to match new tags

* reset indention w feedback passes linting locally

* adding skip support and skipping rpm and deb tests

* back to fixing linting for tags now

Co-authored-by: Manuel de la Peña <mdelapenya@gmail.com>
mdelapenya added a commit to mdelapenya/e2e-testing that referenced this issue Dec 2, 2020
@EricDavisX @mdelapenya
work for issue elastic#379 - adding back rpm and deb tests (elastic#439)
89b4f1b 
* adding back rpm and deb tests

* arbitrary change to trigger ci tests

* fix linting

* fixing more linting

* fully exploring gherkin linting apparently

* final linting fix

* updating ci suites to match new tags

* reset indention w feedback passes linting locally

* adding skip support and skipping rpm and deb tests

* back to fixing linting for tags now

Co-authored-by: Manuel de la Peña <mdelapenya@gmail.com>
mdelapenya added a commit that referenced this issue Dec 2, 2020
@mdelapenya @EricDavisX
[7.10.x] Backport (#521)
11925ba 
* work for issue #379 - adding back rpm and deb tests (#439)

* adding back rpm and deb tests

* arbitrary change to trigger ci tests

* fix linting

* fixing more linting

* fully exploring gherkin linting apparently

* final linting fix

* updating ci suites to match new tags

* reset indention w feedback passes linting locally

* adding skip support and skipping rpm and deb tests

* back to fixing linting for tags now

Co-authored-by: Manuel de la Peña <mdelapenya@gmail.com>

* fix: use proper gherkin comments (#519)

Co-authored-by: Eric Davis <eric.davis@elastic.co>
mdelapenya added a commit that referenced this issue Dec 2, 2020
@mdelapenya @EricDavisX
[7.x] Backports (#522)
4291ad8 
* work for issue #379 - adding back rpm and deb tests (#439)

* adding back rpm and deb tests

* arbitrary change to trigger ci tests

* fix linting

* fixing more linting

* fully exploring gherkin linting apparently

* final linting fix

* updating ci suites to match new tags

* reset indention w feedback passes linting locally

* adding skip support and skipping rpm and deb tests

* back to fixing linting for tags now

Co-authored-by: Manuel de la Peña <mdelapenya@gmail.com>

* fix: use proper gherkin comments (#519)

Co-authored-by: Eric Davis <eric.davis@elastic.co>
@EricDavisX
Copy link
Contributor Author

the DEB and RPM tests are back in master but not backported yet, by backport tooling isn't working right (it is for Kibana, but not for e2e-testing repo...) need to figure that out. : /

@EricDavisX
Copy link
Contributor Author

backports are here - got my tool working:
#544
#545

@EricDavisX
Copy link
Contributor Author

done done

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Team:Elastic-Agent Label for the Agent team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@EricDavisX