This repository has been archived by the owner on Sep 17, 2024. It is now read-only.
fix: use proper gherkin comments #519
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Merging as the parser works again. Thanks! |
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
💚 Flaky test reportTests succeeded. Expand to view the summary
Test stats 🧪
|
|
thanks - yes, i misread the proper Gherkin comment format, and used Golang and merged it before someone more experienced could review. bad process and i should be more careful in the future. thanks for the help in cleaning it up. |
mdelapenya
added a commit
to mdelapenya/e2e-testing
that referenced
this pull request
Dec 2, 2020
mdelapenya
added a commit
to mdelapenya/e2e-testing
that referenced
this pull request
Dec 2, 2020
mdelapenya
added a commit
that referenced
this pull request
Dec 2, 2020
* work for issue #379 - adding back rpm and deb tests (#439) * adding back rpm and deb tests * arbitrary change to trigger ci tests * fix linting * fixing more linting * fully exploring gherkin linting apparently * final linting fix * updating ci suites to match new tags * reset indention w feedback passes linting locally * adding skip support and skipping rpm and deb tests * back to fixing linting for tags now Co-authored-by: Manuel de la Peña <mdelapenya@gmail.com> * fix: use proper gherkin comments (#519) Co-authored-by: Eric Davis <eric.davis@elastic.co>
mdelapenya
added a commit
that referenced
this pull request
Dec 2, 2020
* work for issue #379 - adding back rpm and deb tests (#439) * adding back rpm and deb tests * arbitrary change to trigger ci tests * fix linting * fixing more linting * fully exploring gherkin linting apparently * final linting fix * updating ci suites to match new tags * reset indention w feedback passes linting locally * adding skip support and skipping rpm and deb tests * back to fixing linting for tags now Co-authored-by: Manuel de la Peña <mdelapenya@gmail.com> * fix: use proper gherkin comments (#519) Co-authored-by: Eric Davis <eric.davis@elastic.co>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
It uses proper Gherkin syntax for comments
Why is it important?
The feature file cannot be parsed, failing the build
Checklist
make noticein the proper directory)Related issues