This repository has been archived by the owner on Sep 17, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 42
fix: agent directories must belong to root #2590
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdelapenya
added
Team:Automation
Label for the Observability productivity team
backport-v7.17.0
Automated backport with mergify
backport-v8.2.0
Automated backport with mergify
backport-v8.3.0
Automated backport with mergify
labels
Jun 1, 2022
mdelapenya
removed
backport-v8.2.0
Automated backport with mergify
backport-v7.17.0
Automated backport with mergify
labels
Jun 1, 2022
💔 Tests Failed
Expand to view the summary
Build stats
Test stats 🧪
Test errorsExpand to view the tests failures
|
cachedout
approved these changes
Jun 2, 2022
kuisathaverat
approved these changes
Jun 2, 2022
mergify bot
pushed a commit
that referenced
this pull request
Jun 2, 2022
* chore: store agent pat into the metadata struct of the agent package * chore: create agent directories for UNIX-based agent installers (cherry picked from commit 274a01a)
mdelapenya
added a commit
that referenced
this pull request
Jun 2, 2022
mdelapenya
added a commit
to mdelapenya/e2e-testing
that referenced
this pull request
Jun 3, 2022
* chore: store agent pat into the metadata struct of the agent package * chore: create agent directories for UNIX-based agent installers
mdelapenya
added a commit
to mdelapenya/e2e-testing
that referenced
this pull request
Jun 3, 2022
* main: Add test scenario for elastic agent tags (elastic#2552) bump stack version 8.4.0-3525aaf7 (elastic#2597) bump stack version 8.4.0-df27a645 (elastic#2591) fix: agent directories must belong to root (elastic#2590)
mdelapenya
added a commit
to mdelapenya/e2e-testing
that referenced
this pull request
Jun 3, 2022
* main: Add test scenario for elastic agent tags (elastic#2552) bump stack version 8.4.0-3525aaf7 (elastic#2597) bump stack version 8.4.0-df27a645 (elastic#2591) fix: agent directories must belong to root (elastic#2590) chore: bump maintenance versions in mergify (elastic#2563)
mdelapenya
added a commit
that referenced
this pull request
Jun 3, 2022
* docs: document AWS requirements * fix: typo * fix: agent directories must belong to root (#2590) * chore: store agent pat into the metadata struct of the agent package * chore: create agent directories for UNIX-based agent installers * bump stack version 8.4.0-df27a645 (#2591) Co-authored-by: apmmachine <infra-root-apmmachine@elastic.co> Co-authored-by: Manuel de la Peña <mdelapenya@gmail.com> * bump stack version 8.4.0-3525aaf7 (#2597) Co-authored-by: apmmachine <infra-root-apmmachine@elastic.co> * Add test scenario for elastic agent tags (#2552) * add flags * gitignore * gitignore * typo * quotes * remove quotes * remove restart * Update e2e/_suites/fleet/fleet.go Co-authored-by: Manuel de la Peña <social.mdelapenya@gmail.com> Co-authored-by: Manuel de la Peña <social.mdelapenya@gmail.com> * docs: improve docs about adding a new platform * docs: better explained that there are more files Co-authored-by: apmmachine <58790750+apmmachine@users.noreply.github.com> Co-authored-by: apmmachine <infra-root-apmmachine@elastic.co> Co-authored-by: Mariana Dima <mariana@elastic.co>
mergify bot
pushed a commit
that referenced
this pull request
Jun 3, 2022
* docs: document AWS requirements * fix: typo * fix: agent directories must belong to root (#2590) * chore: store agent pat into the metadata struct of the agent package * chore: create agent directories for UNIX-based agent installers * bump stack version 8.4.0-df27a645 (#2591) Co-authored-by: apmmachine <infra-root-apmmachine@elastic.co> Co-authored-by: Manuel de la Peña <mdelapenya@gmail.com> * bump stack version 8.4.0-3525aaf7 (#2597) Co-authored-by: apmmachine <infra-root-apmmachine@elastic.co> * Add test scenario for elastic agent tags (#2552) * add flags * gitignore * gitignore * typo * quotes * remove quotes * remove restart * Update e2e/_suites/fleet/fleet.go Co-authored-by: Manuel de la Peña <social.mdelapenya@gmail.com> Co-authored-by: Manuel de la Peña <social.mdelapenya@gmail.com> * docs: improve docs about adding a new platform * docs: better explained that there are more files Co-authored-by: apmmachine <58790750+apmmachine@users.noreply.github.com> Co-authored-by: apmmachine <infra-root-apmmachine@elastic.co> Co-authored-by: Mariana Dima <mariana@elastic.co> (cherry picked from commit bea0ea7)
mergify bot
pushed a commit
that referenced
this pull request
Jun 3, 2022
* docs: document AWS requirements * fix: typo * fix: agent directories must belong to root (#2590) * chore: store agent pat into the metadata struct of the agent package * chore: create agent directories for UNIX-based agent installers * bump stack version 8.4.0-df27a645 (#2591) Co-authored-by: apmmachine <infra-root-apmmachine@elastic.co> Co-authored-by: Manuel de la Peña <mdelapenya@gmail.com> * bump stack version 8.4.0-3525aaf7 (#2597) Co-authored-by: apmmachine <infra-root-apmmachine@elastic.co> * Add test scenario for elastic agent tags (#2552) * add flags * gitignore * gitignore * typo * quotes * remove quotes * remove restart * Update e2e/_suites/fleet/fleet.go Co-authored-by: Manuel de la Peña <social.mdelapenya@gmail.com> Co-authored-by: Manuel de la Peña <social.mdelapenya@gmail.com> * docs: improve docs about adding a new platform * docs: better explained that there are more files Co-authored-by: apmmachine <58790750+apmmachine@users.noreply.github.com> Co-authored-by: apmmachine <infra-root-apmmachine@elastic.co> Co-authored-by: Mariana Dima <mariana@elastic.co> (cherry picked from commit bea0ea7)
mergify bot
pushed a commit
that referenced
this pull request
Jun 3, 2022
* docs: document AWS requirements * fix: typo * fix: agent directories must belong to root (#2590) * chore: store agent pat into the metadata struct of the agent package * chore: create agent directories for UNIX-based agent installers * bump stack version 8.4.0-df27a645 (#2591) Co-authored-by: apmmachine <infra-root-apmmachine@elastic.co> Co-authored-by: Manuel de la Peña <mdelapenya@gmail.com> * bump stack version 8.4.0-3525aaf7 (#2597) Co-authored-by: apmmachine <infra-root-apmmachine@elastic.co> * Add test scenario for elastic agent tags (#2552) * add flags * gitignore * gitignore * typo * quotes * remove quotes * remove restart * Update e2e/_suites/fleet/fleet.go Co-authored-by: Manuel de la Peña <social.mdelapenya@gmail.com> Co-authored-by: Manuel de la Peña <social.mdelapenya@gmail.com> * docs: improve docs about adding a new platform * docs: better explained that there are more files Co-authored-by: apmmachine <58790750+apmmachine@users.noreply.github.com> Co-authored-by: apmmachine <infra-root-apmmachine@elastic.co> Co-authored-by: Mariana Dima <mariana@elastic.co> (cherry picked from commit bea0ea7)
mdelapenya
added a commit
that referenced
this pull request
Jun 6, 2022
* docs: document AWS requirements * fix: typo * fix: agent directories must belong to root (#2590) * chore: store agent pat into the metadata struct of the agent package * chore: create agent directories for UNIX-based agent installers * bump stack version 8.4.0-df27a645 (#2591) Co-authored-by: apmmachine <infra-root-apmmachine@elastic.co> Co-authored-by: Manuel de la Peña <mdelapenya@gmail.com> * bump stack version 8.4.0-3525aaf7 (#2597) Co-authored-by: apmmachine <infra-root-apmmachine@elastic.co> * Add test scenario for elastic agent tags (#2552) * add flags * gitignore * gitignore * typo * quotes * remove quotes * remove restart * Update e2e/_suites/fleet/fleet.go Co-authored-by: Manuel de la Peña <social.mdelapenya@gmail.com> Co-authored-by: Manuel de la Peña <social.mdelapenya@gmail.com> * docs: improve docs about adding a new platform * docs: better explained that there are more files Co-authored-by: apmmachine <58790750+apmmachine@users.noreply.github.com> Co-authored-by: apmmachine <infra-root-apmmachine@elastic.co> Co-authored-by: Mariana Dima <mariana@elastic.co> (cherry picked from commit bea0ea7) Co-authored-by: Manuel de la Peña <mdelapenya@gmail.com>
mdelapenya
added a commit
that referenced
this pull request
Jun 6, 2022
* docs: document AWS requirements * fix: typo * fix: agent directories must belong to root (#2590) * chore: store agent pat into the metadata struct of the agent package * chore: create agent directories for UNIX-based agent installers * bump stack version 8.4.0-df27a645 (#2591) Co-authored-by: apmmachine <infra-root-apmmachine@elastic.co> Co-authored-by: Manuel de la Peña <mdelapenya@gmail.com> * bump stack version 8.4.0-3525aaf7 (#2597) Co-authored-by: apmmachine <infra-root-apmmachine@elastic.co> * Add test scenario for elastic agent tags (#2552) * add flags * gitignore * gitignore * typo * quotes * remove quotes * remove restart * Update e2e/_suites/fleet/fleet.go Co-authored-by: Manuel de la Peña <social.mdelapenya@gmail.com> Co-authored-by: Manuel de la Peña <social.mdelapenya@gmail.com> * docs: improve docs about adding a new platform * docs: better explained that there are more files Co-authored-by: apmmachine <58790750+apmmachine@users.noreply.github.com> Co-authored-by: apmmachine <infra-root-apmmachine@elastic.co> Co-authored-by: Mariana Dima <mariana@elastic.co> (cherry picked from commit bea0ea7) Co-authored-by: Manuel de la Peña <mdelapenya@gmail.com>
mdelapenya
added a commit
that referenced
this pull request
Jun 6, 2022
* docs: document AWS requirements * fix: typo * fix: agent directories must belong to root (#2590) * chore: store agent pat into the metadata struct of the agent package * chore: create agent directories for UNIX-based agent installers * bump stack version 8.4.0-df27a645 (#2591) Co-authored-by: apmmachine <infra-root-apmmachine@elastic.co> Co-authored-by: Manuel de la Peña <mdelapenya@gmail.com> * bump stack version 8.4.0-3525aaf7 (#2597) Co-authored-by: apmmachine <infra-root-apmmachine@elastic.co> * Add test scenario for elastic agent tags (#2552) * add flags * gitignore * gitignore * typo * quotes * remove quotes * remove restart * Update e2e/_suites/fleet/fleet.go Co-authored-by: Manuel de la Peña <social.mdelapenya@gmail.com> Co-authored-by: Manuel de la Peña <social.mdelapenya@gmail.com> * docs: improve docs about adding a new platform * docs: better explained that there are more files Co-authored-by: apmmachine <58790750+apmmachine@users.noreply.github.com> Co-authored-by: apmmachine <infra-root-apmmachine@elastic.co> Co-authored-by: Mariana Dima <mariana@elastic.co> (cherry picked from commit bea0ea7) Co-authored-by: Manuel de la Peña <mdelapenya@gmail.com>
mdelapenya
added a commit
to mdelapenya/e2e-testing
that referenced
this pull request
Jun 17, 2022
* main: (22 commits) chore(jjbb): increase build timeout to 2h (elastic#2661) chore: increase build timeout to 2h (elastic#2660) feat: run tests on windows 2019 (elastic#2468) Remove aws instance reaper Jenkins job (elastic#2647) Update k8s version to v1.24 (elastic#2644) chore: simplify extracting info from the supported platforms (elastic#2637) ci: avoid running on branches that are not available anymore (elastic#2627) Add support for Debian 11 and Ubuntu 22.04 platforms (elastic#2603) fix: retire 8.1 snapshot from upgrades (elastic#2616) bump stack version 8.4.0-42ce0eef (elastic#2613) docs: document AWS requirements (elastic#2589) chore: move elastic-agent's k8s-autodiscover scenarios from beats to elastic-agent profile (elastic#2601) Add test scenario for elastic agent tags (elastic#2552) bump stack version 8.4.0-3525aaf7 (elastic#2597) bump stack version 8.4.0-df27a645 (elastic#2591) fix: agent directories must belong to root (elastic#2590) chore: bump maintenance versions in mergify (elastic#2563) chore: bump kubernetes versions (elastic#2562) fix: use fixed, valid version for protobuffers (elastic#2569) chore: do not run apm-server helm chart scenarios for Beats (elastic#2564) ...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
backport-v8.3.0
Automated backport with mergify
Team:Automation
Label for the Observability productivity team
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
It adds a new field in the struct representing the agent metadata to store the base path where the agent will be installed under Linux/Darwin systems.
This path will be created in the target system at the PreInstall phase, so that it has the right permissions beforehand.
Why is it important?
This agent path, according to elastic/elastic-agent#398, must belong to
root
. And this applies only to 8.3 and main.Checklist
make unit-test
), and they are passing locallymake notice
in the proper directory)Related issues