Skip to content
This repository has been archived by the owner on Sep 17, 2024. It is now read-only.

fix: retire 8.1 snapshot from upgrades #2616

Merged
merged 1 commit into from
Jun 6, 2022
Merged

fix: retire 8.1 snapshot from upgrades #2616

merged 1 commit into from
Jun 6, 2022

Conversation

mdelapenya
Copy link
Contributor

What does this PR do?

It retires 8.1-SNAPSHOT from the stale versions used to upgrade an agent in the main branch. Instead of using that snapshot, we are using the latest released version for 8.1, which is 8.1.3

Why is it important?

The 8.1-SNAPSHOT dissapeared from the Elastic artifacts.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have run the Unit tests (make unit-test), and they are passing locally
  • I have run the End-2-End tests for the suite I'm working on, and they are passing locally
  • I have noticed new Go dependencies (run make notice in the proper directory)

Related issues

@mdelapenya mdelapenya added Team:Automation Label for the Observability productivity team backport-v8.3.0 Automated backport with mergify labels Jun 6, 2022
@mdelapenya mdelapenya self-assigned this Jun 6, 2022
@mdelapenya mdelapenya requested review from jlind23, michalpristas and a team June 6, 2022 16:33
mdelapenya
mdelapenya commented Jun 6, 2022
View reviewed changes
e2e/_suites/fleet/features/upgrade_agent.feature
@@ -14,6 +14,6 @@ Examples: Stale versions
| latest |
| 8.2-SNAPSHOT |
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jlind23 @ph we should start upgrading from 8.3 to main in the main branch too

v1v
v1v reviewed Jun 6, 2022
View reviewed changes
e2e/_suites/fleet/features/upgrade_agent.feature
@@ -14,6 +14,6 @@ Examples: Stale versions
| latest |
| 8.2-SNAPSHOT |
| 8.2.0 |
| 8.1-SNAPSHOT |
| 8.1.3 |
| 8.1.0 |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can 8.1.3 supersede the 8.1.0?

Suggested change
| 8.1.0 |

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There was an upgrade error in 8.1.1 and 8.1.2, that's why I kept the 8.1.0 as the initial good state for the upgrade before the wrong states.

Other than that I'm OK with removing it.

@elasticmachine
Copy link
Contributor

elasticmachine commented Jun 6, 2022 •
edited
Loading

💔 Tests Failed

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-06-06T20:44:12.687+0000

  • Duration: 66 min 47 sec

Test stats 🧪

Test Results
Failed 1
Passed 317
Skipped 0
Total 318

Test errors 1

Expand to view the tests failures

Initializing / End-To-End Tests / fleet_debian_arm64_system_integration / Adding network system/metrics Integration to a Policy – System Integration
    Expand to view the error details

     Step the agent is listed in Fleet as "online"

  • no stacktrace

Steps errors 4

Expand to view the steps failures

Executing ansible-playbook
  • Took 14 min 13 sec . View more details here
  • Description: /var/lib/jenkins/workspace/2e-tests_e2e-testing-mbp_PR-2616/.venv/bin/ansible-playbook --private-key="/var/lib/jenkins/workspace/2e-tests_e2e-testing-mbp_PR-2616/src/github.com/elastic/e2e-testing/e2essh" --extra-vars="workspace=/var/lib/jenkins/workspace/2e-tests_e2e-testing-mbp_PR-2616/src/github.com/elastic/e2e-testing/ runId=dd7c3c05 sshPublicKey=/var/lib/jenkins/workspace/2e-tests_e2e-testing-mbp_PR-2616/src/github.com/elastic/e2e-testing/e2essh.pub" --ssh-common-args='-o StrictHostKeyChecking=no -o UserKnownHostsFile=/dev/null' /var/lib/jenkins/workspace/2e-tests_e2e-testing-mbp_PR-2616/src/github.com/elastic/e2e-testing/.ci/ansible/playbook.yml -i "3.16.150.86," -t setup-stack --extra-vars="buildURL=https://beats-ci.elastic.co/job/e2e-tests/job/e2e-testing-mbp/job/PR-2616/3/ gitSha=a31e48d80e70b4f1415f535fafb8c859de547d87 build=3 repo=e2e-testing branch=pr-2616 type=ci stackRunner=3.16.150.86 nodeLabel=stack nodeUser=admin nodeImage=ami-0d90bed76900e679a nodeInstanceType=t3.xlarge"
Sleep
  • Took 0 min 5 sec . View more details here
  • Description: 5
Shell Script
  • Took 19 min 2 sec . View more details here
  • Description: ssh -tt -o TCPKeepAlive=yes -o ServerAliveInterval=60 -o ServerAliveCountMax=10 -o StrictHostKeyChecking=no -o UserKnownHostsFile=/dev/null -i /var/lib/jenkins/workspace/PR-2616-3-0a3aebf1-02d5-4a63-acc5-3184e7e878b4/e2essh admin@3.142.151.191 -- 'sudo bash /home/admin/e2e-testing/.ci/scripts/functional-test.sh'
Archive the artifacts
  • Took 0 min 1 sec . View more details here
  • Description: [2022-06-06T21:48:33.429Z] Archiving artifacts script returned exit code 2

🐛 Flaky test report

❕ There are test failures but not known flaky tests.

Expand to view the summary

Genuine test errors 1

💔 There are test failures but not known flaky tests, most likely a genuine test failure.

  • Name: Initializing / End-To-End Tests / fleet_debian_arm64_system_integration / Adding network system/metrics Integration to a Policy – System Integration

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@mdelapenya mdelapenya merged commit d0f73e0 into elastic:main Jun 6, 2022
mergify bot pushed a commit that referenced this pull request Jun 6, 2022
@mdelapenya @mergify
fix: retire 8.1 snapshot from upgrades (#2616)
84f7bc2 
(cherry picked from commit d0f73e0)
@mergify mergify bot mentioned this pull request Jun 6, 2022
Merged
mdelapenya added a commit that referenced this pull request Jun 6, 2022
@mergify @mdelapenya
fix: retire 8.1 snapshot from upgrades (#2616) (#2618)
5cbc910 
(cherry picked from commit d0f73e0)

Co-authored-by: Manuel de la Peña <mdelapenya@gmail.com>
v1v added a commit to v1v/e2e-testing that referenced this pull request Jun 7, 2022
@v1v
Merge remote-tracking branch 'upstream/main' into jlind23/MacOS12-sup…
5965193 
…port

* upstream/main:
  Add support for Debian 11 and Ubuntu 22.04 platforms (elastic#2603)
  fix: retire 8.1 snapshot from upgrades (elastic#2616)
@mdelapenya mdelapenya deleted the fix-upgrades-main branch June 13, 2022 08:51
mdelapenya added a commit to mdelapenya/e2e-testing that referenced this pull request Jun 14, 2022
@mdelapenya
Merge branch 'main' into 2338-bring-back-windows-support
50f51b4 
* main:
  Add support for Debian 11 and Ubuntu 22.04 platforms (elastic#2603)
  fix: retire 8.1 snapshot from upgrades (elastic#2616)
  bump stack version 8.4.0-42ce0eef (elastic#2613)
  docs: document AWS requirements (elastic#2589)
  chore: move elastic-agent's k8s-autodiscover scenarios from beats to elastic-agent profile (elastic#2601)
mdelapenya added a commit to mdelapenya/e2e-testing that referenced this pull request Jun 17, 2022
@mdelapenya
Merge branch 'main' into unify-local-ci-dev-experience
8606c37 
* main: (22 commits)
  chore(jjbb): increase build timeout to 2h (elastic#2661)
  chore: increase build timeout to 2h (elastic#2660)
  feat: run tests on windows 2019 (elastic#2468)
  Remove aws instance reaper Jenkins job (elastic#2647)
  Update k8s version to v1.24 (elastic#2644)
  chore: simplify extracting info from the supported platforms (elastic#2637)
  ci: avoid running on branches that are not available anymore (elastic#2627)
  Add support for Debian 11 and Ubuntu 22.04 platforms (elastic#2603)
  fix: retire 8.1 snapshot from upgrades (elastic#2616)
  bump stack version 8.4.0-42ce0eef (elastic#2613)
  docs: document AWS requirements (elastic#2589)
  chore: move elastic-agent's k8s-autodiscover scenarios from beats to elastic-agent profile (elastic#2601)
  Add test scenario for elastic agent tags (elastic#2552)
  bump stack version 8.4.0-3525aaf7 (elastic#2597)
  bump stack version 8.4.0-df27a645 (elastic#2591)
  fix: agent directories must belong to root (elastic#2590)
  chore: bump maintenance versions in mergify (elastic#2563)
  chore: bump kubernetes versions (elastic#2562)
  fix: use fixed, valid version for protobuffers (elastic#2569)
  chore: do not run apm-server helm chart scenarios for Beats (elastic#2564)
  ...
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@v1v v1v v1v approved these changes

@jlind23 jlind23 Awaiting requested review from jlind23

@michalpristas michalpristas Awaiting requested review from michalpristas

Assignees

@mdelapenya mdelapenya

Labels
backport-v8.3.0 Automated backport with mergify Team:Automation Label for the Observability productivity team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mdelapenya @elasticmachine @v1v