Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fit functions for stacked line and area charts #450

Closed
3 tasks done
nickofthyme opened this issue Nov 13, 2019 · 1 comment · Fixed by #751
Closed
3 tasks done

Fit functions for stacked line and area charts #450

nickofthyme opened this issue Nov 13, 2019 · 1 comment · Fixed by #751
Labels
:data Data/series/scales related issue enhancement New feature or request released Issue released publicly :xy Bar/Line/Area chart related

Comments

@nickofthyme
Copy link
Collaborator

nickofthyme commented Nov 13, 2019 •
edited
Loading

Is your feature request related to a problem? Please describe.
Lens would like to have the ability to create stacked area/line charts with null y1 data.

#388

Describe the solution you'd like
The solution would be to use the fit function logic implemented in the non-stacked charts.

Describe alternatives you've considered
Currently, the workaround is to fill the null data in kibana or have a strange-looking chart

image

Additional context
To do this for stacked charts requires each successive series to know the values of the series below at that point. If series a has no explicit value at x = 1 but has an interpolated value of 2 based on the bounding values, then we need to first find the missing value to enable stacking of series b at x=1.

Further complications come into play when adding a curve type to the series, where the calculated value is not exact.

Checklist

  • this request is checked against already exist requests
  • every related Kibana issue is listed under Kibana Cross Issues list
  • kibana cross issue tag is associated to the issue if any kibana cross issue is present
@nickofthyme nickofthyme added the enhancement New feature or request label Nov 13, 2019
nickofthyme added a commit that referenced this issue Nov 13, 2019
@nickofthyme
feat: fit functions for null y1 values (#416)
e083755 
Add ability to fit data of non-stacked line and area charts with a specified fit function type
* add fit functions for null y1 values
* allow end values to be explicitly set as fallback
* add visual regression tests
* add unit tests and better testing utils

Note: Does not *yet* support stacked charts or `y0` values. This is a future enhancement is being tracked in #450.

related to #388
markov00 pushed a commit that referenced this issue Nov 13, 2019
@semantic-release-bot
chore(release): 14.1.0 [skip ci]
898a33f 
# [14.1.0](v14.0.0...v14.1.0) (2019-11-13)

### Features

* fit functions for null y1 values ([#416](#416)) ([e083755](e083755)), closes [#450](#450) [#388](#388)
@markov00 markov00 added :data Data/series/scales related issue :xy Bar/Line/Area chart related labels Mar 26, 2020
@markov00 markov00 mentioned this issue Jul 15, 2020
Merged
3 tasks
markov00 added a commit that referenced this issue Jul 29, 2020
@markov00
feat: streamgraph and fit functions on stacked charts (#751)
268fcc0 
This commit adds the wiggle and silhouette stacks mode as available in vislib that allow the creation of streamgraph. It is also to fix fit functions for stacked charts. The commit also add the following fixes:
- fit functions are now available also on stacked charts
- the legend extra value is now displayed, on-demand, only on charts with a continuous x-axis
- Adjusts slightly the way fitted data is represented in the case of null values and no fit option specified. It renders an empty area in this case
- for zero-based charts (bar and area charts) the fit option doesn't have any effects
- djusts the clipped ranges for ordinal charts, where the lines where wrongly clipped due to a missing translate call when rendering

BREAKING CHANGE: the first parameter of `PointStyleAccessor` and `BarStyleAccessor` callbacks is changed from `RawDataSeriesDatum` to `DataSeriesDatum`. `stackAsPercentage` prop is replaced by `stackMode` that accept one `StackMode`.

fix #766
fix #715
close #450
markov00 pushed a commit that referenced this issue Aug 10, 2020
@semantic-release-bot
chore(release): 21.0.0 [skip ci]
e7a8a30 
# [21.0.0](v20.0.2...v21.0.0) (2020-08-10)

### Bug Fixes

* update dep vulnerabilities, minimist and kind-of ([#763](#763)) ([4455281](4455281))
* **legend:** fix color anchor, add action context, fix action padding ([#774](#774)) ([4590a22](4590a22))
* **tooltip:** placement with left/top legends and single bars ([#771](#771)) ([e576b26](e576b26)), closes [#769](#769) [#770](#770)

### Features

* streamgraph and fit functions on stacked charts ([#751](#751)) ([268fcc0](268fcc0)), closes [#766](#766) [#715](#715) [#450](#450)

### BREAKING CHANGES

* the first parameter of `PointStyleAccessor` and `BarStyleAccessor` callbacks is changed from `RawDataSeriesDatum` to `DataSeriesDatum`. `stackAsPercentage` prop is replaced by `stackMode` that accept one `StackMode`.
@markov00
Copy link
Member

🎉 This issue has been resolved in version 21.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@markov00 markov00 added the released Issue released publicly label Aug 10, 2020
AMoo-Miki pushed a commit to AMoo-Miki/OpenSearch-Dashboards that referenced this issue Feb 10, 2022
@semantic-release-bot
chore(release): 14.1.0 [skip ci]
7e77227 
# [14.1.0](elastic/elastic-charts@v14.0.0...v14.1.0) (2019-11-13)

### Features

* fit functions for null y1 values ([opensearch-project#416](elastic/elastic-charts#416)) ([6462cff](elastic/elastic-charts@6462cff)), closes [opensearch-project#450](elastic/elastic-charts#450) [opensearch-project#388](elastic/elastic-charts#388)
AMoo-Miki pushed a commit to AMoo-Miki/OpenSearch-Dashboards that referenced this issue Feb 10, 2022
@semantic-release-bot
chore(release): 21.0.0 [skip ci]
5c68eec 
# [21.0.0](elastic/elastic-charts@v20.0.2...v21.0.0) (2020-08-10)

### Bug Fixes

* update dep vulnerabilities, minimist and kind-of ([opensearch-project#763](elastic/elastic-charts#763)) ([843554f](elastic/elastic-charts@843554f))
* **legend:** fix color anchor, add action context, fix action padding ([opensearch-project#774](elastic/elastic-charts#774)) ([262f8d2](elastic/elastic-charts@262f8d2))
* **tooltip:** placement with left/top legends and single bars ([opensearch-project#771](elastic/elastic-charts#771)) ([75533b1](elastic/elastic-charts@75533b1)), closes [opensearch-project#769](elastic/elastic-charts#769) [opensearch-project#770](elastic/elastic-charts#770)

### Features

* streamgraph and fit functions on stacked charts ([opensearch-project#751](elastic/elastic-charts#751)) ([6f6a8cb](elastic/elastic-charts@6f6a8cb)), closes [opensearch-project#766](elastic/elastic-charts#766) [opensearch-project#715](elastic/elastic-charts#715) [opensearch-project#450](elastic/elastic-charts#450)

### BREAKING CHANGES

* the first parameter of `PointStyleAccessor` and `BarStyleAccessor` callbacks is changed from `RawDataSeriesDatum` to `DataSeriesDatum`. `stackAsPercentage` prop is replaced by `stackMode` that accept one `StackMode`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
:data Data/series/scales related issue enhancement New feature or request released Issue released publicly :xy Bar/Line/Area chart related
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: wiggle and silhouette stacks markov00/elastic-charts
2 participants
@markov00 @nickofthyme