Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not use x-opaque-id for deprecations originated from Kibana #82810

Closed
pgomulka opened this issue Jan 19, 2022 · 2 comments
Closed

Do not use x-opaque-id for deprecations originated from Kibana #82810

pgomulka opened this issue Jan 19, 2022 · 2 comments
Labels
blocker >bug Team:Core/Infra Meta label for core/infra team v7.17.0

Comments

@pgomulka
Copy link
Contributor

pgomulka commented Jan 19, 2022 •
edited
Loading

Kibana is at the moment using x-opaque-id with a UUID which is causing a deprecation log throttling to not work. A new unique value on x-opaque-id is causing that every deprecation is considered unique.

We need to implement a workaround to exclude requests originating from Kibana from using x-opaque-id when emitting a deprecation log.

a workaround to elastic/kibana#120124

edit: x-opaque-id won't be use for deprecation log throttling for any requests originating from elastic stack (x-elastic-product-origin present)
@pgomulka pgomulka added >bug blocker needs:triage Requires assignment of a team area label v7.17.0 labels Jan 19, 2022
@rdnm rdnm added the Team:Core/Infra Meta label for core/infra team label Jan 19, 2022
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (Team:Core/Infra)

@jtibshirani jtibshirani removed the needs:triage Requires assignment of a team area label label Jan 19, 2022
pgomulka added a commit to pgomulka/elasticsearch that referenced this issue Jan 20, 2022
@pgomulka
Do no use x-opaque-id for deduplicating kibana requests
909a1f6 
deprecated log messages originating from kibana's requests should not be
deduplicated with the use of x-opaque-id because kibana populates it
with UUID.

closes elastic#82810
@pgomulka pgomulka mentioned this issue Jan 20, 2022
Merged
pgomulka added a commit that referenced this issue Jan 25, 2022
@pgomulka
Do no use x-opaque-id for deduplicating elastic originating requests (#…
f416b67 
…82855)

deprecated log messages originating from any elastic product requests should not be
deduplicated with the use of x-opaque-id.
If present, the value of X-elastic-product-origin will be used as part of the throttling key.

relates #82810
pgomulka added a commit to pgomulka/elasticsearch that referenced this issue Jan 25, 2022
@pgomulka
Do no use x-opaque-id for deduplicating elastic originating requests (e…
cc0765d 
…lastic#82855)

deprecated log messages originating from any elastic product requests should not be
deduplicated with the use of x-opaque-id.
If present, the value of X-elastic-product-origin will be used as part of the throttling key.

relates elastic#82810
pgomulka added a commit to pgomulka/elasticsearch that referenced this issue Jan 25, 2022
@pgomulka
Do no use x-opaque-id for deduplicating elastic originating requests …
04bd69e 
…backport (elastic#82855)

deprecated log messages originating from any elastic product requests should not be
deduplicated with the use of x-opaque-id.
If present, the value of X-elastic-product-origin will be used as part of the throttling key.

relates elastic#82810
@pgomulka pgomulka mentioned this issue Jan 25, 2022
Merged
pgomulka added a commit that referenced this issue Jan 25, 2022
@pgomulka
Do no use x-opaque-id for deduplicating elastic originating requests …
47f1348 
…backport (#82855) (#83023)

deprecated log messages originating from any elastic product requests should not be
deduplicated with the use of x-opaque-id.
If present, the value of X-elastic-product-origin will be used as part of the throttling key.

relates #82810
backport #82855
@pgomulka
Copy link
Contributor Author

closing by #82855 and backports to 8.0 and 7.17

@pgomulka pgomulka mentioned this issue Apr 25, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
blocker >bug Team:Core/Infra Meta label for core/infra team v7.17.0
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@albertzaharovits @jtibshirani @pgomulka @elasticmachine @rdnm