Do no use x-opaque-id for deduplicating Elastic originating requests
#82855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deprecated log messages originating from kibana's requests should not be deduplicated with the use of x-opaque-id because kibana populates it with UUID. closes elastic#82810
| * @see <a href="https://logging.apache.org/log4j/2.x/manual/filters.htmlf">Log4j2 Filters</a> | ||
| */ | ||
| @Plugin(name = "RateLimitingFilter", category = Node.CATEGORY, elementType = Filter.ELEMENT_TYPE) | ||
| public class RateLimitingFilter extends AbstractFilter { | ||
|
|
||
| private volatile boolean useXOpaqueId = true; | ||
| private static final String KIBANA_OPRDUCT_ORIGIN = "kibana"; |
There was a problem hiding this comment.
is this a typo or intentional?
Suggested change
| private static final String KIBANA_OPRDUCT_ORIGIN = "kibana"; | |
| private static final String KIBANA_PRODUCT_ORIGIN = "kibana"; |
There was a problem hiding this comment.
that was a typo. The constant is not needed as this change will apply to all elastic originating requests
pgomulka
changed the title
pgomulka
added
:Core/Infra/Core
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
pgomulka
added
>enhancement
and removed
:Core/Infra/Core
|
Hi @pgomulka, I've created a changelog YAML for you. |
rjernst
approved these changes
Jan 24, 2022
|
|
||
| private volatile boolean useXOpaqueId = true; | ||
| // a flag to disable/enable use of xOpaqueId controlled by changing cluster setting | ||
| private volatile boolean useXOpaqueIdEnabled = true; |
There was a problem hiding this comment.
Why the addition of "enabled"? The "use" prefix already denotes a boolean.
There was a problem hiding this comment.
true - it does not make sens to me now either. I can't remember what I was thinking when renaming..
…mulka/elasticsearch into disable_xopaqueid_kibana_originating
pgomulka
added
the
auto-backport
pgomulka
added a commit
to pgomulka/elasticsearch
that referenced
this pull request
Jan 25, 2022
…lastic#82855) deprecated log messages originating from any elastic product requests should not be deduplicated with the use of x-opaque-id. If present, the value of X-elastic-product-origin will be used as part of the throttling key. relates elastic#82810
💔 Backport failed
You can use sqren/backport to manually backport by running |
pgomulka
added a commit
to pgomulka/elasticsearch
that referenced
this pull request
Jan 25, 2022
…backport (elastic#82855) deprecated log messages originating from any elastic product requests should not be deduplicated with the use of x-opaque-id. If present, the value of X-elastic-product-origin will be used as part of the throttling key. relates elastic#82810
pgomulka
added a commit
that referenced
this pull request
Jan 25, 2022
albertzaharovits
changed the title
x-opaque-id for deduplicating Elastic originating requests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
deprecated log messages originating from any elastic product requests should not be
deduplicated with the use of x-opaque-id.
If present, the value of
X-elastic-product-originwill be used as part of the throttling key.relates #82810
gradle check?