Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TransportNodesAction impls are local-only #100867

Conversation

DaveCTurner
Copy link
Contributor

@DaveCTurner DaveCTurner commented Oct 14, 2023

There are no remote invocations of any actions derived from
TransportNodesAction so there is no need to register the top-level
action with the TransportService, and that means that all the code
related to de/serialization of the top-level request and response is
unused and can be removed.

Relates #100111
Relates #100878

@DaveCTurner

This comment was marked as outdated.

There are no remote invocations of any actions derived from
`TransportNodesAction` so there is no need to register the top-level
action with the `TransportService`, and that means that all the code
related to de/serialization of the top-level request and response is
unused and can be removed.

Relates elastic#100111
Relates elastic#100878
@DaveCTurner DaveCTurner force-pushed the 2023/10/14/TransportNodesAction-local-only branch from 3a677d9 to 3292322 Compare October 16, 2023 05:58
@DaveCTurner DaveCTurner removed the WIP label Oct 16, 2023
@DaveCTurner DaveCTurner marked this pull request as ready for review October 16, 2023 07:01
@elasticsearchmachine elasticsearchmachine added the Team:Core/Infra Meta label for core/infra team label Oct 16, 2023
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (Team:Core/Infra)

@elasticsearchmachine
Copy link
Collaborator

Hi @DaveCTurner, I've created a changelog YAML for you.

@DaveCTurner
Copy link
Contributor Author

Failure is #99422.

@elasticmachine please run elasticsearch-ci/part-2

Copy link
Contributor

@ldematte ldematte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Only a couple of Q:

@DaveCTurner
Copy link
Contributor Author

After #100878 we can come back and change it, right?

Right.

Is there a place where BaseNodeResponse.readNodesFrom and writeNodesTo are not just TransportAction.localOnly();?

Yeah there's a couple of places where the base response is wrapped up in another response that I didn't fancy pulling to bits here, see e.g. org.elasticsearch.xpack.core.analytics.action.AnalyticsStatsAction.Response or org.elasticsearch.xpack.core.spatial.action.SpatialStatsAction.Response, and several more that have nontrivial test suites which I didn't want to unpick here.

@DaveCTurner DaveCTurner added the auto-merge Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) label Oct 17, 2023
@elasticsearchmachine elasticsearchmachine merged commit 596c3cb into elastic:main Oct 17, 2023
13 checks passed
@DaveCTurner DaveCTurner deleted the 2023/10/14/TransportNodesAction-local-only branch October 17, 2023 08:28
DaveCTurner added a commit to DaveCTurner/elasticsearch that referenced this pull request Dec 12, 2023
@DaveCTurner DaveCTurner restored the 2023/10/14/TransportNodesAction-local-only branch June 17, 2024 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-merge Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) :Core/Infra/Transport API Transport client API >non-issue Team:Core/Infra Meta label for core/infra team >tech debt test-update-serverless v8.12.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants