Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Execute local action via client in RemoteClusterNodesAction #100876

Merged
merged 1 commit into from
Oct 16, 2023
Merged

Execute local action via client in RemoteClusterNodesAction #100876

merged 1 commit into from
Oct 16, 2023

Conversation

DaveCTurner
Copy link
Contributor

Rather than sending a nodes-info request to the local node via its
transport service, we should use the Client to invoke the action
directly.

@DaveCTurner
Execute local action via client in RemoteClusterNodesAction
a7828a4 
Rather than sending a nodes-info request to the local node via its
transport service, we should use the `Client` to invoke the action
directly.
@DaveCTurner DaveCTurner added :Distributed/Network Http and internode communication implementations >refactoring v8.12.0 labels Oct 15, 2023
@elasticsearchmachine elasticsearchmachine added the Team:Distributed Meta label for distributed team label Oct 15, 2023
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-distributed (Team:Distributed)

@DaveCTurner
Copy link
Contributor Author

This is the only place we invoke a TransportNodesAction derivative via the TransportService, and by making this change we can drop a bunch of otherwise-unused serialization code (see #100867 and #100111).

ywangd
ywangd approved these changes Oct 16, 2023
View reviewed changes
Copy link
Member

@ywangd ywangd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

It's a good change. Thanks for picking it up.

@DaveCTurner DaveCTurner merged commit cb18463 into elastic:main Oct 16, 2023
12 checks passed
@DaveCTurner DaveCTurner deleted the 2023/10/14/RemoteClusterNodesActionTests-via-client branch October 16, 2023 06:06
@DaveCTurner DaveCTurner restored the 2023/10/14/RemoteClusterNodesActionTests-via-client branch June 17, 2024 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ywangd ywangd ywangd approved these changes

Assignees
No one assigned
Labels
:Distributed/Network Http and internode communication implementations >refactoring Team:Distributed Meta label for distributed team v8.12.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DaveCTurner @elasticsearchmachine @ywangd