Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Rationalize ref-counting around ChannelActionListener (#102551)" #102609

Merged

Conversation

original-brownbear
Copy link
Member

This reverts commit 6f72a1c #102551 , sadly this is still causing ESQL test failures and we need to fix ESQL some more before we can continue here.

@original-brownbear original-brownbear added >non-issue :Distributed/Network Http and internode communication implementations auto-merge Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) labels Nov 24, 2023
@elasticsearchmachine elasticsearchmachine added the Team:Distributed Meta label for distributed team label Nov 24, 2023
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-distributed (Team:Distributed)

Copy link
Contributor

@iverase iverase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elasticsearchmachine elasticsearchmachine merged commit fdf51ac into elastic:main Nov 24, 2023
14 checks passed
@original-brownbear original-brownbear deleted the revert-ref-count-fix branch November 24, 2023 19:55
alex-spies added a commit to alex-spies/elasticsearch that referenced this pull request Nov 27, 2023
leemthompo pushed a commit to leemthompo/elasticsearch that referenced this pull request Nov 27, 2023
…lastic#102638)

* Revert "Revert "Rationalize ref-counting around ChannelActionListener (elastic#102551)" (elastic#102609)"

This reverts commit fdf51ac.

* Fix response ownership in ESQL
timgrein pushed a commit to timgrein/elasticsearch that referenced this pull request Nov 30, 2023
…c#102551)" (elastic#102609)

This reverts commit 6f72a1c elastic#102551 ,
sadly this is still causing ESQL test failures and we need to fix ESQL
some more before we can continue here.
timgrein pushed a commit to timgrein/elasticsearch that referenced this pull request Nov 30, 2023
…lastic#102638)

* Revert "Revert "Rationalize ref-counting around ChannelActionListener (elastic#102551)" (elastic#102609)"

This reverts commit fdf51ac.

* Fix response ownership in ESQL
original-brownbear added a commit to original-brownbear/elasticsearch that referenced this pull request Dec 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-merge Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) :Distributed/Network Http and internode communication implementations >non-issue Team:Distributed Meta label for distributed team v8.12.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants