Rationalize ref-counting around ChannelActionListener (2nd attempt) #102638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alex-spies
added
>non-issue
:Distributed/Distributed
elasticsearchmachine
added
Team:Distributed
|
Pinging @elastic/es-distributed (Team:Distributed) |
|
Pinging @elastic/es-ql (Team:QL) |
|
Pinging @elastic/elasticsearch-esql (:Query Languages/ES|QL) |
original-brownbear
approved these changes
Nov 27, 2023
There was a problem hiding this comment.
LGTM, thanks for the quick turnaround here @alex-spies ! Feel free to merge this if it goes green in CI, for the benefit of others:
This is just the original PR + the new OwningChannelActionListener which is neatly contained in the QL codebase and for the time being restores the listener behavior to what it was before these changes from the perspective of some of the QL code here until that can be fixed.
78 tasks
alex-spies
deleted the
rationalize-ref-counting-around-channelactionlistener
branch
timgrein
pushed a commit
to timgrein/elasticsearch
that referenced
this pull request
Nov 30, 2023
…lastic#102638) * Revert "Revert "Rationalize ref-counting around ChannelActionListener (elastic#102551)" (elastic#102609)" This reverts commit fdf51ac. * Fix response ownership in ESQL
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a second attempt at #102551.