Extend request lifecycle in RestReloadSecureSettingsAction #103953
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The security module doesn't refcount requests properly, see elastic#103952, so async auth flows may discard the keystore password before the request is processed. This commit adjusts the action to retain the request until the response is available, which unfortunately negates the improvement in elastic#103757.
DaveCTurner
added
>non-issue
:Security/Security
|
Pinging @elastic/es-security (Team:Security) |
|
|
|
I don't have a great idea for how to test this. It'd be good to be sure to cover this in |
jakelandis
approved these changes
Jan 5, 2024
There was a problem hiding this comment.
LGTM
However, have a question raised over at #103952 (comment)
|
Superseded by #104000 |
DaveCTurner
deleted the
2024/01/05/RestReloadSecureSettingsAction-workaround-103952
branch
DaveCTurner
restored the
2024/01/05/RestReloadSecureSettingsAction-workaround-103952
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The security module doesn't refcount requests properly, see #103952, so
async auth flows may discard the keystore password before the request is
processed. This commit adjusts the action to retain the request until
the response is available, which unfortunately negates the improvement
in #103757.