Retain ref to requests when running ActionFilterChain #104000
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`ActionFilter` implementations may be async, so we have to keep the request alive while the chain is running. Closes elastic#103952
DaveCTurner
added
>non-issue
:Core/Infra/Core
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
jakelandis
reviewed
Jan 5, 2024
| final var request = new Request(); | ||
| try { | ||
| client().execute(TYPE, request, ActionListener.<Response>running(countDownLatch::countDown).delegateResponse((delegate, e) -> { | ||
| assertEquals("short-circuit failure", asInstanceOf(ElasticsearchException.class, e).getMessage()); |
There was a problem hiding this comment.
is this guaranteed to always be true ? (due to the random boolean below)
There was a problem hiding this comment.
Yes, it's ok if everything succeeds too, we're just checking that nothing else went wrong. I added a code comment in 84a194c.
rjernst
approved these changes
Jan 8, 2024
|
|
||
| @Override | ||
| protected void doRun() { | ||
| Thread.yield(); |
There was a problem hiding this comment.
Kinda, but really I was just using it to help make sure I had the right things covered by the tests and forgot to remove it. Gone now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ActionFilterimplementations may be async, so we have to keep therequest alive while the chain is running.
Closes #103952