Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

only set vm.max_map_count if greater #31512

Merged
merged 2 commits into from
Jun 28, 2018
Merged

only set vm.max_map_count if greater #31512

merged 2 commits into from
Jun 28, 2018

Conversation

majormoses
Copy link
Contributor

This fixes some logic that was not quite right in #31285 it should only be changed if the value requested is greater than rather than and should not include equality on that.

Signed-off-by: Ben Abrams me@benabrams.it

@majormoses
only set vm.max_map_count if greater
7cb4c20 
Signed-off-by: Ben Abrams <me@benabrams.it>
@jtibshirani jtibshirani added the :Delivery/Packaging RPM and deb packaging, tar and zip archives, shell and batch scripts label Jun 22, 2018
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra

@jtibshirani
Copy link
Contributor

@jasontedor I'm guessing you'd like to take a look, as you reviewed the linked PR.

jasontedor
jasontedor approved these changes Jun 27, 2018
View reviewed changes
Copy link
Member

@jasontedor jasontedor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So the issue here is that we want to avoid setting vm.max_map_count if it is already equal to the desired value (the bootstrap check requires 262144). The reason we want to avoid this is because in some use-cases using sysctl to set this will fail. In this case, we want to enable users to set this value externally and then allow that to cause using sysctl to set the value to be skipped so that cases where using sysctl will fail to no longer fail.

LGTM.

@jasontedor
Copy link
Member

Sorry for the delay @majormoses, I was on vacation last week.

@jasontedor
Copy link
Member

Thanks for the ping @jtibshirani.

@jasontedor
Copy link
Member

@elasticmachine test this please

@jasontedor
Merge remote-tracking branch 'elastic/master' into pr/31512
c41ea16 
* elastic/master: (57 commits)
  HLRest: Fix test for explain API
  [TEST] Fix RemoteClusterConnectionTests
  Add Create Snapshot to High-Level Rest Client (elastic#31215)
  Remove legacy MetaDataStateFormat (elastic#31603)
  Add explain API to high-level REST client (elastic#31387)
  Preserve thread context when connecting to remote cluster (elastic#31574)
  Unify headers for full text queries
  Remove redundant 'minimum_should_match'
  JDBC driver prepared statement set* methods  (elastic#31494)
  [TEST] call yaml client close method from test suite (elastic#31591)
  ingest: Add ignore_missing property to foreach filter (elastic#22147) (elastic#31578)
  Fix a formatting issue in the docvalue_fields documentation. (elastic#31563)
  reduce log level at gradle configuration time
  [TEST] Close additional clients created while running yaml tests (elastic#31575)
  Docs: Clarify sensitive fields watcher encryption (elastic#31551)
  Watcher: Remove never executed code (elastic#31135)
  Add support for switching distribution for all integration tests (elastic#30874)
  Improve robustness of geo shape parser for malformed shapes (elastic#31449)
  QA: Create xpack yaml features (elastic#31403)
  Improve test times for tests using `RandomObjects::addFields` (elastic#31556)
  ...
@jasontedor
Copy link
Member

@elasticmachine test this please

@majormoses
Copy link
Contributor Author

@jasontedor thanks and no worries, I am constantly being pulled off and on that project anyways.

@majormoses
Copy link
Contributor Author

@jasontedor looks like CI passes, let me know if you need anything else from me.

@jasontedor
Copy link
Member

@majormoses Thanks for the check. You're good here; I will merge this later. I am in the middle of some other tasks right now.

@jasontedor jasontedor merged commit 909a18a into elastic:master Jun 28, 2018
jasontedor pushed a commit that referenced this pull request Jun 28, 2018
@majormoses @jasontedor
Only set vm.max_map_count if greater than default (#31512)
f4e154d 
So the issue here is that we want to avoid setting vm.max_map_count if
it is already equal to the desired value (the bootstrap check requires
262144). The reason we want to avoid this is because in some use-cases
using sysctl to set this will fail. In this case, we want to enable
users to set this value externally and then allow that to cause using
sysctl to set the value to be skipped so that cases where using sysctl
will fail to no longer fail.
jasontedor pushed a commit that referenced this pull request Jun 28, 2018
@majormoses @jasontedor
Only set vm.max_map_count if greater than default (#31512)
b4ac570 
So the issue here is that we want to avoid setting vm.max_map_count if
it is already equal to the desired value (the bootstrap check requires
262144). The reason we want to avoid this is because in some use-cases
using sysctl to set this will fail. In this case, we want to enable
users to set this value externally and then allow that to cause using
sysctl to set the value to be skipped so that cases where using sysctl
will fail to no longer fail.
jasontedor pushed a commit that referenced this pull request Jun 28, 2018
@majormoses @jasontedor
Only set vm.max_map_count if greater than default (#31512)
7d17af9 
So the issue here is that we want to avoid setting vm.max_map_count if
it is already equal to the desired value (the bootstrap check requires
262144). The reason we want to avoid this is because in some use-cases
using sysctl to set this will fail. In this case, we want to enable
users to set this value externally and then allow that to cause using
sysctl to set the value to be skipped so that cases where using sysctl
will fail to no longer fail.
dnhatn added a commit that referenced this pull request Jun 28, 2018
@dnhatn
Merge branch 'master' into ccr
2c10cd3 
* master:
  Docs: Remove duplicate test setup
  Print output when the name checker IT fails (#31660)
  Fix syntax errors in get-snapshots docs (#31656)
  Docs: Fix description of percentile ranks example example (#31652)
  Add MultiSearchTemplate support to High Level Rest client (#30836)
  Add test for low-level client round-robin behaviour (#31616)
  SQL: Refactor package names of sql-proto and sql-shared-proto projects (#31622)
  Remove deprecation warnings to prepare for Gradle 5 (sourceSets.main.output.classesDirs) (#30389)
  Correct integTest enable logic (#31646)
  Fix missing get-snapshots docs reference #31645
  Do not check for Azure container existence (#31617)
  Merge AwsS3Service and InternalAwsS3Service in a S3Service class (#31580)
  Upgrade gradle wrapper to 4.8 (#31525)
  Only set vm.max_map_count if greater than default (#31512)
  Add Get Snapshots High Level REST API (#31537)
  QA: Merge query-builder-bwc to restart test (#30979)
  Update reindex.asciidoc (#31626)
  Docs: Skip xpack snippet tests if no xpack (#31619)
  mute CreateSnapshotRequestTests
  HLRest: Fix test for explain API
  [TEST] Fix RemoteClusterConnectionTests
  Add Create Snapshot to High-Level Rest Client (#31215)
  Remove legacy MetaDataStateFormat (#31603)
  Add explain API to high-level REST client (#31387)
  Preserve thread context when connecting to remote cluster (#31574)
  Unify headers for full text queries
  Remove redundant 'minimum_should_match'
  JDBC driver prepared statement set* methods  (#31494)
  [TEST] call yaml client close method from test suite (#31591)
dnhatn added a commit that referenced this pull request Jun 28, 2018
@dnhatn
Merge branch '6.x' into ccr-6.x
8e245a3 
* 6.x:
  Docs: Remove duplicate test setup
  Docs: Fix description of percentile ranks example example (#31652)
  Remove deprecation warnings to prepare for Gradle 5 (sourceSets.main.output.classesDirs) (#30389)
  Do not check for Azure container existence (#31617)
  Merge AwsS3Service and InternalAwsS3Service in a S3Service class (#31580)
  Remove item listed in 6.3 notes that's not in 6.3 (#31623)
  remove unused import
  Upgrade gradle wrapper to 4.8 (#31525)
  Only set vm.max_map_count if greater than default (#31512)
  QA: Merge query-builder-bwc to restart test (#30979)
  Docs: Skip xpack snippet tests if no xpack (#31619)
  [TEST] Fix RemoteClusterConnectionTests
  Remove legacy MetaDataStateFormat (#31603)
  [TEST] call yaml client close method from test suite (#31591)
  [TEST] Close additional clients created while running yaml tests (#31575)
  Node selector per client rather than per request (#31471)
  Preserve thread context when connecting to remote cluster (#31574)
  Remove redundant 'minimum_should_match'
  Unify headers for full text queries
  JDBC driver prepared statement set* methods  (#31494)
  add logging breaking changes from 5.3 to 6.0 (#31583)
  Fix a formatting issue in the docvalue_fields documentation. (#31563)
  Improve robustness of geo shape parser for malformed shapes
  QA: Create xpack yaml features (#31403)
@danielmitterdorfer danielmitterdorfer mentioned this pull request Jan 16, 2019
Closed
@elfranne elfranne mentioned this pull request May 18, 2020
Open
@mark-vieira mark-vieira added the Team:Delivery Meta label for Delivery team label Nov 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasontedor jasontedor jasontedor approved these changes

Assignees
No one assigned
Labels
:Delivery/Packaging RPM and deb packaging, tar and zip archives, shell and batch scripts >non-issue Team:Delivery Meta label for Delivery team v5.6.11 v6.3.1 v6.4.0 v7.0.0-beta1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@majormoses @elasticmachine @jtibshirani @jasontedor @colings86 @mark-vieira