Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SQL: Refactor package names of sql-proto and sql-shared-proto projects #31622

Merged
merged 1 commit into from
Jun 28, 2018
Merged

SQL: Refactor package names of sql-proto and sql-shared-proto projects #31622

merged 1 commit into from
Jun 28, 2018

Conversation

imotov
Copy link
Contributor

@imotov imotov commented Jun 27, 2018

  • renames project sql-proto to sql-action,
  • renames package sql.plugin to sql.action
  • renames project sql-shared-client to sql-client
  • renames package sql.shard.client to sql.client
  • renames project sql-shared-proto to sql-proto

Closes #31593

@imotov
SQL: Refactor package names of sql-proto and sql-shared-proto projects
4d28c6b 
- renames project sql-proto-> sql-action,
- renames package sql.plugin to sql.action
- renames project sql-shared-client -> sql-client
- renames package sql.shard.client to sql.client
- renames project sql-shared-proto -> sql-proto

Closes elastic#31593
@imotov imotov requested a review from costin June 27, 2018 18:50
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search-aggs

@costin
Copy link
Member

costin commented Jun 27, 2018

LGTM

costin
costin approved these changes Jun 28, 2018
View reviewed changes
Copy link
Member

@costin costin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 2

@imotov imotov merged commit 0b1a064 into elastic:master Jun 28, 2018
dnhatn added a commit that referenced this pull request Jun 28, 2018
@dnhatn
Merge branch 'master' into ccr
2c10cd3 
* master:
  Docs: Remove duplicate test setup
  Print output when the name checker IT fails (#31660)
  Fix syntax errors in get-snapshots docs (#31656)
  Docs: Fix description of percentile ranks example example (#31652)
  Add MultiSearchTemplate support to High Level Rest client (#30836)
  Add test for low-level client round-robin behaviour (#31616)
  SQL: Refactor package names of sql-proto and sql-shared-proto projects (#31622)
  Remove deprecation warnings to prepare for Gradle 5 (sourceSets.main.output.classesDirs) (#30389)
  Correct integTest enable logic (#31646)
  Fix missing get-snapshots docs reference #31645
  Do not check for Azure container existence (#31617)
  Merge AwsS3Service and InternalAwsS3Service in a S3Service class (#31580)
  Upgrade gradle wrapper to 4.8 (#31525)
  Only set vm.max_map_count if greater than default (#31512)
  Add Get Snapshots High Level REST API (#31537)
  QA: Merge query-builder-bwc to restart test (#30979)
  Update reindex.asciidoc (#31626)
  Docs: Skip xpack snippet tests if no xpack (#31619)
  mute CreateSnapshotRequestTests
  HLRest: Fix test for explain API
  [TEST] Fix RemoteClusterConnectionTests
  Add Create Snapshot to High-Level Rest Client (#31215)
  Remove legacy MetaDataStateFormat (#31603)
  Add explain API to high-level REST client (#31387)
  Preserve thread context when connecting to remote cluster (#31574)
  Unify headers for full text queries
  Remove redundant 'minimum_should_match'
  JDBC driver prepared statement set* methods  (#31494)
  [TEST] call yaml client close method from test suite (#31591)
imotov added a commit that referenced this pull request Jun 28, 2018
@imotov
SQL: Refactor package names of sql-proto and sql-shared-proto projects (
4d2de5b 
#31622)

- renames project `sql-proto` to `sql-action`,
- renames package `sql.plugin` to `sql.action`
- renames project `sql-shared-client` to `sql-client`
- renames package `sql.shard.client` to `sql.client`
- renames project `sql-shared-proto` to `sql-proto`

Closes #31593
dnhatn added a commit that referenced this pull request Jun 29, 2018
@dnhatn
Merge branch '6.x' into ccr-6.x
71cc05d 
* 6.x:
  Do not check for object existence when deleting repository index files (#31680)
  Remove extra check for object existence in repository-gcs read object (#31661)
  [Test] Clean up some repository-s3 tests (#31601)
  Merge AzureStorageService and AzureStorageServiceImpl and clean up tests (#31607)
  [Docs] Use capital letters in section headings (#31678)
  [DOCS] Add PQL language Plugin (#31237)
  [DOCS] Fix licensing API details (#31667)
  Fix CreateSnapshotRequestTests Failure (#31630)
  Add Create Snapshot to High-Level Rest Client (#31215)
  Add MultiSearchTemplate support to High Level Rest client (#31662)
  SQL: Refactor package names of sql-proto and sql-shared-proto projects (#31622)
  [TEST] Mute failing NamingConventionsTaskIT tests
  [DOCS] Replace CONFIG_DIR with ES_PATH_CONF (#31635)
  Add test for low-level client round-robin behaviour (#31616)
  HLRest: Fix test for explain API
  Add explain API to high-level REST client (#31387)
@imotov imotov deleted the issue-31593-refactor-sql-proto-packages branch May 1, 2020 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@costin costin costin approved these changes

Assignees
No one assigned
Labels
:Analytics/SQL SQL querying >refactoring v6.4.0 v7.0.0-beta1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@imotov @elasticmachine @costin @colings86