[Zen2] Introduce FollowersChecker #33917
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is important that the leader periodically checks that its followers are still healthy and can remain part of its cluster. If these checks fail repeatedly then the leader should remove the faulty node from the cluster. The FollowerChecker, introduced in this commit, performs these periodic checks and deals with retries.
DaveCTurner
added
>enhancement
v7.0.0
:Distributed/Cluster Coordination
|
Pinging @elastic/es-distributed |
ywelsch
reviewed
Sep 21, 2018
server/src/main/java/org/elasticsearch/cluster/coordination/FollowersChecker.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/elasticsearch/cluster/coordination/FollowersChecker.java
Outdated
Show resolved
Hide resolved
| request, this).getFormattedMessage()); | ||
| } | ||
|
|
||
| executeRunnable.accept(new AbstractRunnable() { |
There was a problem hiding this comment.
can you add assert request.term > this.term before this line?
There was a problem hiding this comment.
That doesn't hold - we could be in the correct term but a CANDIDATE (e.g. LeaderChecker thinks the leader failed) and then we need to call into the coordinator and become a FOLLOWER again.
server/src/main/java/org/elasticsearch/cluster/coordination/FollowersChecker.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/elasticsearch/cluster/coordination/FollowersChecker.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/elasticsearch/cluster/coordination/FollowersChecker.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/elasticsearch/cluster/coordination/FollowersChecker.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/elasticsearch/cluster/coordination/FollowersChecker.java
Outdated
Show resolved
Hide resolved
server/src/test/java/org/elasticsearch/cluster/coordination/FollowersCheckerTests.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/elasticsearch/cluster/coordination/FollowersChecker.java
Show resolved
Hide resolved
|
@elasticmachine test this please |
61 tasks
ywelsch
added a commit
that referenced
this pull request
Sep 28, 2018
Allows this class to be cleanly shared between Zen1 and Zen2. Follow-up to #33917
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is important that the leader periodically checks that its followers are
still healthy and can remain part of its cluster. If these checks fail
repeatedly then the leader should remove the faulty node from the cluster. The
FollowerChecker, introduced in this commit, performs these periodic checks and
deals with retries.