Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zen2: Move NodeRemovalClusterStateTaskExecutor out of ZenDiscovery #34147

Merged
merged 1 commit into from
Sep 28, 2018

Conversation

ywelsch
Copy link
Contributor

@ywelsch ywelsch commented Sep 28, 2018

Allows this class to be cleanly shared between Zen1 and Zen2. Follow-up to #33917

Note to reviewer: Despite the diff looking so large, this is just straight-forward moving of code. No intended change to the behavior was done.

@ywelsch ywelsch added >non-issue v7.0.0 :Distributed/Cluster Coordination Cluster formation and cluster state publication, including cluster membership and fault detection. labels Sep 28, 2018
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-distributed

@ywelsch ywelsch mentioned this pull request Sep 28, 2018
61 tasks
Copy link
Contributor

@DaveCTurner DaveCTurner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Basically impossible to review as a diff, so I just did the same refactoring myself and came to the same answer.

@ywelsch ywelsch merged commit 412face into elastic:zen2 Sep 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Distributed/Cluster Coordination Cluster formation and cluster state publication, including cluster membership and fault detection. >non-issue v7.0.0-beta1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants