Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC] document transform settings and docs_per_second #56178

Merged
merged 3 commits into from
May 11, 2020

Conversation

hendrikmuhs
Copy link
Contributor

@hendrikmuhs hendrikmuhs commented May 5, 2020

add documentation for throttling, added in #56007

/CC @szabosteve @lcawl - if you like, you can take this over

@hendrikmuhs hendrikmuhs added >docs General docs changes v8.0.0 :ml/Transform Transform v7.8.0 labels May 5, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-docs (>docs)

@elasticmachine elasticmachine added the Team:Docs Meta label for docs team label May 5, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/ml-core (:ml/Transform)

@@ -125,9 +125,6 @@ include::{docdir}/rest-api/common-parms.asciidoc[tag=pivot-aggs]
(Required, object)
include::{docdir}/rest-api/common-parms.asciidoc[tag=pivot-group-by]

`max_page_search_size`:::
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This setting has been deprecated and moved to the settings part. I therefore removed the old mention, this might not be best-practice.

@hendrikmuhs hendrikmuhs force-pushed the transform-document-throttling branch from ae6b673 to 5721c9c Compare May 11, 2020 05:58
@hendrikmuhs hendrikmuhs marked this pull request as ready for review May 11, 2020 06:32
Copy link
Contributor

@szabosteve szabosteve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this Hendrik! LGTM!

@hendrikmuhs hendrikmuhs merged commit a73511e into elastic:master May 11, 2020
@hendrikmuhs hendrikmuhs deleted the transform-document-throttling branch May 11, 2020 07:21
hendrikmuhs pushed a commit that referenced this pull request May 11, 2020
add documentation for throttling, added in #56007
hendrikmuhs pushed a commit that referenced this pull request May 11, 2020
add documentation for throttling, added in #56007
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>docs General docs changes :ml/Transform Transform Team:Docs Meta label for docs team v7.8.0 v7.9.0 v8.0.0-alpha1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants