Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Add throttling based on configuration parameter #56653

Merged
merged 3 commits into from
May 14, 2020

Conversation

@lcawl lcawl added >docs General docs changes v8.0.0 :ml/Transform Transform v7.8.0 v7.9.0 labels May 12, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-docs (>docs)

@elasticmachine elasticmachine added the Team:Docs Meta label for docs team label May 12, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/ml-core (:ml/Transform)

data it processes. Also consider whether the cluster has sufficient resources in
place to support both the composite aggregation search and the indexing of its
results. You can also throttle the rate at which {transforms} perform search and
index requests by setting `docs_per_second` when you <<put-transform,create>> or
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and index requests

Is this correct that indexing is also affected by this setting?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, by slowing down the searches, you slow down indexing, too.

Maybe add a sentence that the transform will take longer if throttling is used, although this seems obvious?

and maybe something like:

To know the current docs_per_second transform is operating you can take a look into stats (-> link to stats) and calculate the rate with:

docs_per_second = documents_processed / search_time_in_ms * 1000

(^ I plan to add this to the stats endpoint, however not for 7.8)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I've added that information in a final paragraph.

@lcawl lcawl requested a review from hendrikmuhs May 13, 2020 00:29
@lcawl lcawl marked this pull request as ready for review May 13, 2020 00:29
Copy link
Contributor

@hendrikmuhs hendrikmuhs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! added a suggestion.

data it processes. Also consider whether the cluster has sufficient resources in
place to support both the composite aggregation search and the indexing of its
results. You can also throttle the rate at which {transforms} perform search and
index requests by setting `docs_per_second` when you <<put-transform,create>> or
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, by slowing down the searches, you slow down indexing, too.

Maybe add a sentence that the transform will take longer if throttling is used, although this seems obvious?

and maybe something like:

To know the current docs_per_second transform is operating you can take a look into stats (-> link to stats) and calculate the rate with:

docs_per_second = documents_processed / search_time_in_ms * 1000

(^ I plan to add this to the stats endpoint, however not for 7.8)

@@ -128,6 +128,23 @@ include::{docdir}/rest-api/common-parms.asciidoc[tag=pivot-group-by]
====
//End pivot

//Begin settings
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 sorry for the bad placement! I see, it should be ordered, will do better next time!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No worries!

@hendrikmuhs
Copy link
Contributor

Still LGTM!

@lcawl lcawl merged commit d7735d9 into elastic:master May 14, 2020
@lcawl lcawl deleted the throttle branch May 14, 2020 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>docs General docs changes :ml/Transform Transform Team:Docs Meta label for docs team v7.8.0 v7.9.0 v8.0.0-alpha1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants