Fix range queries on runtime double field #71915
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbuescher
added
>bug
:Search/Search
|
Pinging @elastic/es-search (Team:Search) |
DoubleScriptFieldRangeQuery which is used on runtime fields of type "double" currently uses simple double type comparison for checking its upper and lower bounds. Unfortunately it seems that -0.0 == 0.0, but when we want to exclude a 0.0 bound via "lt" the generated range query uses -0.0 as its upper bound which erroneously includes the 0.0 value. We can use `Double.compare` instead which seems to handle this edge case well. Closes elastic#71786
|
@elasticmachine run elasticsearch-ci/bwc |
|
@elasticmachine update branch |
cbuescher
pushed a commit
that referenced
this pull request
Apr 20, 2021
DoubleScriptFieldRangeQuery which is used on runtime fields of type "double" currently uses simple double type comparison for checking its upper and lower bounds. Unfortunately it seems that -0.0 == 0.0, but when we want to exclude a 0.0 bound via "lt" the generated range query uses -0.0 as its upper bound which erroneously includes the 0.0 value. We can use `Double.compare` instead which seems to handle this edge case well. Closes #71786
cbuescher
pushed a commit
that referenced
this pull request
Apr 20, 2021
DoubleScriptFieldRangeQuery which is used on runtime fields of type "double" currently uses simple double type comparison for checking its upper and lower bounds. Unfortunately it seems that -0.0 == 0.0, but when we want to exclude a 0.0 bound via "lt" the generated range query uses -0.0 as its upper bound which erroneously includes the 0.0 value. We can use `Double.compare` instead which seems to handle this edge case well. Closes #71786
|
thanks for fixing this @cbuescher ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DoubleScriptFieldRangeQuery which is used on runtime fields of type "double"
currently uses simple double type comparison for checking its upper and lower
bounds. Unfortunately it seems that -0.0 == 0.0, but when we want to exclude a
0.0 bound via "lt" the generated range query uses -0.0 as its upper bound which
erroneously includes the 0.0 value. We can use
Double.compareinstead whichseems to handle this edge case well.
Closes #71786