Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix range queries on runtime double field #71915

Merged
merged 2 commits into from
Apr 20, 2021
Merged

Fix range queries on runtime double field #71915

merged 2 commits into from
Apr 20, 2021

Commits on Apr 20, 2021

  1. Fix range queries on runtime double field 

    DoubleScriptFieldRangeQuery which is used on runtime fields of type "double"
currently uses simple double type comparison for checking its upper and lower
bounds. Unfortunately it seems that -0.0 == 0.0, but when we want to exclude a
0.0 bound via "lt" the generated range query uses -0.0 as its upper bound which
erroneously includes the 0.0 value. We can use `Double.compare` instead which
seems to handle this edge case well.

Closes elastic#71786
    Christoph Büscher committed Apr 20, 2021
    Configuration menu
    Copy the full SHA
    f3cfb3d View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into fix-71786

    @elasticmachine
    elasticmachine authored Apr 20, 2021
    Configuration menu
    Copy the full SHA
    253c1be View commit details
    Browse the repository at this point in the history