Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] make p_value scoring tests more robust #75629

Merged
merged 3 commits into from
Jul 22, 2021
Merged

[ML] make p_value scoring tests more robust #75629

merged 3 commits into from
Jul 22, 2021

Conversation

benwtrent
Copy link
Member

closes: #75601

@benwtrent benwtrent added >test Issues or PRs that are addressing/adding tests :ml Machine learning v8.0.0 auto-backport Automatically create backport pull requests when merged v7.15.0 labels Jul 22, 2021
@elasticmachine elasticmachine added the Team:ML Meta label for the ML team label Jul 22, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/ml-core (Team:ML)

@mayya-sharipova mayya-sharipova mentioned this pull request Jul 22, 2021
Closed
droberts195
droberts195 approved these changes Jul 22, 2021
View reviewed changes
Copy link
Contributor

@droberts195 droberts195 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@benwtrent benwtrent merged commit ff6ec59 into elastic:master Jul 22, 2021
@benwtrent benwtrent deleted the test/ml-p_value_heuristic-test-fix branch July 22, 2021 18:11
elasticsearchmachine pushed a commit to elasticsearchmachine/elasticsearch that referenced this pull request Jul 22, 2021
@benwtrent
[ML] make p_value scoring tests more robust (elastic#75629)
7642821 
closes: elastic#75601
@elasticsearchmachine elasticsearchmachine mentioned this pull request Jul 22, 2021
Merged
@elasticsearchmachine
Copy link
Collaborator

💚 Backport successful

Status Branch Result
✅ 7.x

elasticsearchmachine added a commit that referenced this pull request Jul 22, 2021
@elasticsearchmachine @benwtrent
[ML] make p_value scoring tests more robust (#75629) (#75643)
ec5f392 
closes: #75601

Co-authored-by: Benjamin Trent <ben.w.trent@gmail.com>
ywangd pushed a commit to ywangd/elasticsearch that referenced this pull request Jul 30, 2021
@benwtrent @ywangd
[ML] make p_value scoring tests more robust (elastic#75629)
c707eed 
closes: elastic#75601
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@droberts195 droberts195 droberts195 approved these changes

Assignees
No one assigned
Labels
auto-backport Automatically create backport pull requests when merged :ml Machine learning Team:ML Meta label for the ML team >test Issues or PRs that are addressing/adding tests v7.15.0 v8.0.0-alpha1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[CI] PValueScoreTests testLowPValueScore failing
5 participants
@benwtrent @elasticmachine @elasticsearchmachine @droberts195 @jakelandis