Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate ignore_throttled parameter #77864

Merged
merged 6 commits into from
Sep 16, 2021
Merged

Deprecate ignore_throttled parameter #77864

merged 6 commits into from
Sep 16, 2021

Commits on Sep 16, 2021

  1. Deprecate ignore_throttled parameter 

    Backporting elastic#77479 to 7.x branch.

Frozen indices are deprecated, which will make ignore_throttled obsolete.

Some changes to HLRC  HLRC and related tests were required in order to deprecate ignore_throttled parameter:
* Change HLRC request classes to set indices options initial value to null.
    This avoids sending the ignore_throttled parameter (and other indices options parameters)
    and therefore avoids the depracation warning header in the response. All these
    request classes had the indices options set to what is the defaukt in the corresponding
    action request class. So sending these indices options params was a noop, which is the same
    as not sending indices options parameters, which is what this change does.
* For transport action request classes that are reused in the HLRC as request class,
    change the corresponding hlrc request converter to only send indices options params
    if the indices options are different than what the default is.
* For tests that use a non default indices options, allow 'ignore_throttled is deprecated'
    warning.

Other changes:
* A number of tests have been changed to allowed warning header for deprecated ignore_throttled parameter.
* Some rest v7 compat yaml tests are temporary muted, but will be unmuted once this
    change has been backported.

Relates to elastic#70192
    @martijnvg
    martijnvg committed Sep 16, 2021
    Configuration menu
    Copy the full SHA
    9e24356 View commit details
    Browse the repository at this point in the history

  2. adjust to 7.x reality

    @martijnvg
    martijnvg committed Sep 16, 2021
    Configuration menu
    Copy the full SHA
    54b6834 View commit details
    Browse the repository at this point in the history

  3. adjust to 7.x reality (2)

    @martijnvg
    martijnvg committed Sep 16, 2021
    Configuration menu
    Copy the full SHA
    f1e870b View commit details
    Browse the repository at this point in the history

  4. adjust 7.x request converters

    @martijnvg
    martijnvg committed Sep 16, 2021
    Configuration menu
    Copy the full SHA
    96c9c0c View commit details
    Browse the repository at this point in the history

  5. Merge remote-tracking branch 'es/7.x' into backport_77479

    @martijnvg
    martijnvg committed Sep 16, 2021
    Configuration menu
    Copy the full SHA
    22e1e9e View commit details
    Browse the repository at this point in the history

  6. more 7.x adjustments

    @martijnvg
    martijnvg committed Sep 16, 2021
    Configuration menu
    Copy the full SHA
    a7404a9 View commit details
    Browse the repository at this point in the history