Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

better exception message for MappingParser.parse #80696

Merged
merged 1 commit into from
Nov 15, 2021
Merged

better exception message for MappingParser.parse #80696

merged 1 commit into from
Nov 15, 2021

Conversation

weizijun
Copy link
Contributor

not only _parent cause the exception, every meta field that format error will case the exception.

@elasticsearchmachine elasticsearchmachine added external-contributor Pull request authored by a developer outside the Elasticsearch team v8.1.0 labels Nov 15, 2021
@nik9000 nik9000 added the :Search Foundations/Mapping Index mappings, including merging and defining field types label Nov 15, 2021
@elasticmachine elasticmachine added the Team:Search Meta label for search team label Nov 15, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search (Team:Search)

@nik9000 nik9000 added the >bug label Nov 15, 2021
@romseygeek
Copy link
Contributor

@elasticmachine test this please

romseygeek
romseygeek approved these changes Nov 15, 2021
View reviewed changes
Copy link
Contributor

@romseygeek romseygeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, thanks @weizijun!

@romseygeek romseygeek merged commit 3ca033f into elastic:master Nov 15, 2021
@weizijun
Copy link
Contributor Author

Nice catch, thanks @weizijun!

@romseygeek thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romseygeek romseygeek romseygeek approved these changes

Assignees
No one assigned
Labels
>bug external-contributor Pull request authored by a developer outside the Elasticsearch team :Search Foundations/Mapping Index mappings, including merging and defining field types Team:Search Meta label for search team v8.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@weizijun @elasticmachine @romseygeek @nik9000 @elasticsearchmachine