Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

better exception message for MappingParser.parse #80696

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@ private Mapping parse(String type, Map<String, Object> mapping) throws MapperPar
if (typeParser != null) {
iterator.remove();
if (false == fieldNode instanceof Map) {
throw new IllegalArgumentException("[_parent] must be an object containing [type]");
throw new IllegalArgumentException("[" + fieldName + "] config must be an object");
}
@SuppressWarnings("unchecked")
Map<String, Object> fieldNodeMap = (Map<String, Object>) fieldNode;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -133,4 +133,13 @@ public void testMultiFieldsWithFieldAlias() throws IOException {
);
assertEquals("Type [alias] cannot be used in multi field", e.getMessage());
}

public void testBadMetadataMapper() throws IOException {
XContentBuilder builder = topMapping(b -> { b.field(RoutingFieldMapper.NAME, "required"); });
IllegalArgumentException e = expectThrows(
IllegalArgumentException.class,
() -> createMappingParser(Settings.EMPTY).parse("_doc", new CompressedXContent(BytesReference.bytes(builder)))
);
assertEquals("[_routing] config must be an object", e.getMessage());
}
}