Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add EuiColorPaletteDisplay #3865

Merged
merged 46 commits into from
Nov 5, 2020
Merged

Add EuiColorPaletteDisplay #3865

merged 46 commits into from
Nov 5, 2020

Conversation

miukimiu
Copy link
Contributor

@miukimiu miukimiu commented Aug 5, 2020 •
edited
Loading

Summary

Closes #3575

This PR adds a new component called EuiColorPaletteDisplay. This component used to be part of the EuiColorPalettePicker but it was decided to decouple the code from it. So it can be used on its own.

Issues that this component fix

When this component was part of the EuiColorPalettePicker I found a few issues that are now fixed:

  • We couldn't display only one color
  • Only gradient palettes could have stops. Now also fixed palettes can have stops.

Decisions

While developing this component I found a few issues that lead me to take a few decisions. Initially I was generating a css linear gradient to create fixed color palettes. But on Google chrome, the stops were getting blurred.

Screenshot 2020-10-26 at 19 07 58

For this reason, I tried to generate the linear gradient with an SVG <linearGradient /> but once again the stops were getting blurred.

The solution was to generate color stops with a flex container and spans. There was an issue to use the inset shadow with a flex container. For this reason, I used the mixin @include innerBorder('dark', $euiBorderRadius, .2); to generate the borders.

Final Solution

Color palette display@2x

Checklist

  • Check against all themes for compatibility in both light and dark modes
  • Checked in mobile
  • Checked in Chrome, Safari, Edge, and Firefox
  • Props have proper autodocs
  • Added documentation
  • [ ] Checked Code Sandbox works for the any docs examples
  • Added or updated jest tests
  • Checked for breaking changes and labeled appropriately
  • Checked for accessibility including keyboard-only and screenreader modes
  • A changelog entry exists and is marked appropriately

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_3865/

@miukimiu
Copy link
Contributor Author

miukimiu commented Aug 6, 2020

jenkins test this

@miukimiu miukimiu mentioned this pull request Sep 2, 2020
Merged
3 tasks
@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_3865/

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_3865/

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_3865/

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_3865/

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_3865/

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_3865/

@miukimiu miukimiu marked this pull request as ready for review October 27, 2020 16:55
@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_3865/

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_3865/

thompsongl
thompsongl suggested changes Nov 2, 2020
View reviewed changes
Copy link
Contributor

@thompsongl thompsongl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! A couple TS changes and a couple questions below.

src/components/color_picker/color_palette_display/color_palette_display_fixed.tsx Outdated Show resolved Hide resolved
src/components/color_picker/color_palette_display/color_palette_display_fixed.tsx Outdated Show resolved Hide resolved
src/components/color_picker/utils.ts Outdated Show resolved Hide resolved
src/components/color_picker/utils.ts Show resolved Hide resolved
@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_3865/

cchaos
cchaos suggested changes Nov 3, 2020
View reviewed changes
Copy link
Contributor

@cchaos cchaos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really like that the select box in the customize popover also accounts for the settings. 👍

Just a couple quick last comments.

src-docs/src/views/color_picker/color_palette_display.js Outdated Show resolved Hide resolved
src-docs/src/views/color_picker/color_picker_example.js Outdated Show resolved Hide resolved
src-docs/src/views/color_picker/color_picker_example.js Outdated Show resolved Hide resolved
src/components/color_picker/color_palette_display/color_palette_display_gradient.tsx Outdated Show resolved Hide resolved
src/components/color_picker/color_palette_display/color_palette_display_fixed.tsx Outdated Show resolved Hide resolved
src/components/color_picker/color_palette_display/color_palette_display.tsx Show resolved Hide resolved
src/components/color_picker/color_palette_display/_color_palette_display.scss Outdated Show resolved Hide resolved
@thompsongl
Copy link
Contributor

PR4U: miukimiu#6

@miukimiu
Merge pull request #6 from thompsongl/add-color-palette-display
63cdbab 
EuiColorPaletteDisplay TypeScript assist
@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_3865/

@miukimiu
Copy link
Contributor Author

miukimiu commented Nov 4, 2020

Thanks @thompsongl and @cchaos,

I already merged the PR with the typescript assist and went through the last comments.

@miukimiu miukimiu requested a review from cchaos November 4, 2020 11:56
@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_3865/

cchaos
cchaos approved these changes Nov 5, 2020
View reviewed changes
Copy link
Contributor

@cchaos cchaos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍰 Nice!

thompsongl
thompsongl approved these changes Nov 5, 2020
View reviewed changes
Copy link
Contributor

@thompsongl thompsongl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎨 LGTM!

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_3865/

@miukimiu miukimiu merged commit 671a075 into elastic:master Nov 5, 2020
@chandlerprall chandlerprall mentioned this pull request Nov 23, 2020
Closed
@chandlerprall chandlerprall mentioned this pull request Dec 1, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cchaos cchaos cchaos approved these changes

@thompsongl thompsongl thompsongl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Color Palette Display component
4 participants
@miukimiu @kibanamachine @thompsongl @cchaos