[Docs] Improved EuiMarkdownEditor chart plugin example #3995
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_3995/ |
miukimiu
changed the title
chandlerprall
suggested changes
Sep 3, 2020
src-docs/src/views/markdown_editor/markdown_editor_with_plugins.js
Outdated
Show resolved
Hide resolved
src-docs/src/views/markdown_editor/markdown_editor_with_plugins.js
Outdated
Show resolved
Hide resolved
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_3995/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR closes #3906 and improves the chart plugin example.
I decided to change the
heightfunctionality in favor of picking a number ofcategories. Changing theheightwas creating overflow issues inside the modal.I replaced the EuiSelect with EuiColorPalettePicker. I found that the EuiColorPalettePicker has a bug when we only have one color. But this bug is going to be fixed with Add EuiColorPaletteDisplay #3865.
New design
Checklist
[ ] Checked in mobile[ ] Props have proper autodocs[ ] Checked Code Sandbox works for the any docs examples[ ] Added or updated jest tests[ ] Checked for breaking changes and labeled appropriately[ ] Checked for accessibility including keyboard-only and screenreader modes[ ] A changelog entry exists and is marked appropriately