Sensitive information is already being redacted from diagnostics #190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the troubleshooting guide needs to be updated due to this merge: elastic/elastic-agent#566
adding review comments
karenzone
reviewed
May 12, 2023
| IMPORTANT: The configuration files in the archive may have credentials in *plain text*. | ||
| These will need to be manually redacted before the archive is shared. | ||
| IMPORTANT: {agent} attempts to automatically redact credentials and API keys when creating diagnostics. | ||
| Please review the contents of the archive before sharing to ensure there are no credentials in plain text. |
There was a problem hiding this comment.
Suggested change
| Please review the contents of the archive before sharing to ensure there are no credentials in plain text. | |
| Please review the contents of the archive before sharing to ensure that there are no credentials in plain text. |
There was a problem hiding this comment.
Please consider adding "that" for easier parsing, especially by international audiences
There was a problem hiding this comment.
@nimarezainia, will you please give this a 👍 so we can get it merged? Looks good from a docs POV.
…idoc Co-authored-by: Karen Metts <35154725+karenzone@users.noreply.github.com>
nimarezainia
approved these changes
Jun 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The troubleshooting guide needs to be updated due to this merge: elastic/elastic-agent#566
Replaces elastic/observability-docs#2849.