Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sensitive information is already being redacted from diagnostics #2849

Closed
wants to merge 2 commits into from

Conversation

nimarezainia
Copy link
Contributor

the troubleshooting guide needs to be updated due to this merge: elastic/elastic-agent#566

the troubleshooting guide needs to be updated due to this merge: elastic/elastic-agent#566
@nimarezainia nimarezainia requested a review from a team as a code owner April 9, 2023 06:16
@github-actions
Copy link
Contributor

github-actions bot commented Apr 9, 2023

A documentation preview will be available soon:

@mergify
Copy link
Contributor

mergify bot commented Apr 9, 2023

This pull request does not have a backport label. Could you fix it @nimarezainia? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-/d./d is the label to automatically backport to the /d./d branch. /d is the digit
    NOTE: backport-skip has been added to this pull request.

@mergify mergify bot added the backport-skip Skip notification from the automated backport with mergify label Apr 9, 2023
Copy link
Contributor

@dedemorton dedemorton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I think you want to backport this to 8.4, no? If so, don't forget to add the backport labels.

@nimarezainia
Copy link
Contributor Author

i'll wait for @cmacknz to confirm. I'm seeing some conflicting data that this may actually had been inadvertently undone by the V2 project.

Craig, could you please confirm if this is an issue currently.

@mergify
Copy link
Contributor

mergify bot commented Apr 12, 2023

This pull request is now in conflict. Could you fix it @nimarezainia? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b nimarezainia-patch-5 upstream/nimarezainia-patch-5
git merge upstream/main
git push upstream nimarezainia-patch-5

@bmorelli25
Copy link
Member

We just moved the ingest documentation to elastic/ingest-docs. Once we hear back from @cmacknz, I'll handle opening a new PR and backporting.

@bmorelli25
Copy link
Member

@cmacknz can you confirm if this is still an issue

adding review comments
@nimarezainia
Copy link
Contributor Author

@bmorelli25 I made the recommended changes. hope this doesn't conflict with what you suggested here

@bmorelli25
Copy link
Member

Thanks, both! I've cherry-picked Nima's commits to the new ingest-docs repository. I'm going to close this PR in favor of elastic/ingest-docs#190.

@bmorelli25 bmorelli25 closed this May 2, 2023
@bmorelli25 bmorelli25 deleted the nimarezainia-patch-5 branch May 2, 2023 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-skip Skip notification from the automated backport with mergify
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants