Skip to content

Commit

Permalink
removes flakiness from prebuilt rules (#127137)
Browse files Browse the repository at this point in the history
  • Loading branch information
MadameSheema authored Mar 8, 2022
1 parent 7936381 commit 0a06242
Showing 1 changed file with 0 additions and 17 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@ import {
} from '../../screens/alerts_detection_rules';

import {
changeRowsPerPageTo100,
deleteFirstRule,
deleteSelectedRules,
loadPrebuiltDetectionRules,
Expand Down Expand Up @@ -97,8 +96,6 @@ describe('Actions with prebuilt rules', () => {
});

it('Does not allow to delete one rule when more than one is selected', () => {
changeRowsPerPageTo100();

const numberOfRulesToBeSelected = 2;
selectNumberOfRules(numberOfRulesToBeSelected);

Expand All @@ -108,14 +105,10 @@ describe('Actions with prebuilt rules', () => {
});

it('Deletes and recovers one rule', () => {
changeRowsPerPageTo100();

const expectedNumberOfRulesAfterDeletion = totalNumberOfPrebuiltRules - 1;
const expectedNumberOfRulesAfterRecovering = totalNumberOfPrebuiltRules;

deleteFirstRule();
cy.reload();
changeRowsPerPageTo100();

cy.get(ELASTIC_RULES_BTN).should(
'have.text',
Expand All @@ -128,26 +121,19 @@ describe('Actions with prebuilt rules', () => {

cy.get(RELOAD_PREBUILT_RULES_BTN).should('not.exist');

cy.reload();
changeRowsPerPageTo100();

cy.get(ELASTIC_RULES_BTN).should(
'have.text',
`Elastic rules (${expectedNumberOfRulesAfterRecovering})`
);
});

it('Deletes and recovers more than one rule', () => {
changeRowsPerPageTo100();

const numberOfRulesToBeSelected = 2;
const expectedNumberOfRulesAfterDeletion = totalNumberOfPrebuiltRules - 2;
const expectedNumberOfRulesAfterRecovering = totalNumberOfPrebuiltRules;

selectNumberOfRules(numberOfRulesToBeSelected);
deleteSelectedRules();
cy.reload();
changeRowsPerPageTo100();

cy.get(RELOAD_PREBUILT_RULES_BTN).should('exist');
cy.get(RELOAD_PREBUILT_RULES_BTN).should(
Expand All @@ -163,9 +149,6 @@ describe('Actions with prebuilt rules', () => {

cy.get(RELOAD_PREBUILT_RULES_BTN).should('not.exist');

cy.reload();
changeRowsPerPageTo100();

cy.get(ELASTIC_RULES_BTN).should(
'have.text',
`Elastic rules (${expectedNumberOfRulesAfterRecovering})`
Expand Down

0 comments on commit 0a06242

Please sign in to comment.