Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security Solution] Removes flakiness from prebuilt rules Cypress tests #127137

Merged

Conversation

MadameSheema
Copy link
Member

Summary

Deletes and recovers more than one rule has started to fail in several PRs.

After checking the code, I realized we are doing some actions that are not adding value/related to the behavior we want to test on that spec. Those actions are slowing down the execution time of the tests therefore, we are increasing the flakiness probability.

In this PR we are removing those actions.

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@MadameSheema MadameSheema marked this pull request as ready for review March 8, 2022 13:28
@MadameSheema MadameSheema requested a review from a team as a code owner March 8, 2022 13:28
@MadameSheema MadameSheema self-assigned this Mar 8, 2022
@MadameSheema MadameSheema added v8.1.1 v8.2.0 Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Detection Rule Management Security Detection Rule Management Team Team:Detections and Resp Security Detection Response Team labels Mar 8, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-detections-response (Team:Detections and Resp)

@MadameSheema MadameSheema added auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes labels Mar 8, 2022
Copy link
Contributor

@xcrzx xcrzx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for this clean up 👍

@MadameSheema MadameSheema merged commit 0a06242 into elastic:main Mar 8, 2022
@MadameSheema MadameSheema deleted the cypress/fixes-prebuilt-rule branch March 8, 2022 13:37
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.1

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine pushed a commit that referenced this pull request Mar 8, 2022
kibanamachine added a commit that referenced this pull request Mar 8, 2022
(cherry picked from commit 0a06242)

Co-authored-by: Gloria Hornero <gloria.hornero@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes Team:Detection Rule Management Security Detection Rule Management Team Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v8.1.1 v8.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants