-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Security Solution] Removes flakiness from prebuilt rules Cypress tests #127137
[Security Solution] Removes flakiness from prebuilt rules Cypress tests #127137
Conversation
💚 Build SucceededMetrics [docs]
To update your PR or re-run it, just comment with: |
Pinging @elastic/security-solution (Team: SecuritySolution) |
Pinging @elastic/security-detections-response (Team:Detections and Resp) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for this clean up 👍
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
(cherry picked from commit 0a06242)
Summary
Deletes and recovers more than one rule
has started to fail in several PRs.After checking the code, I realized we are doing some actions that are not adding value/related to the behavior we want to test on that spec. Those actions are slowing down the execution time of the tests therefore, we are increasing the flakiness probability.
In this PR we are removing those actions.