removing some unnecessary memoizations

elastic · Feb 19, 2021 · 0b40493 · 0b40493
1 parent 673019b
commit 0b40493
Showing 1 changed file with 4 additions and 16 deletions.
diff --git a/...plugins/lens/public/editor_frame_service/editor_frame/workspace_panel/workspace_panel.tsx b/...plugins/lens/public/editor_frame_service/editor_frame/workspace_panel/workspace_panel.tsx
@@ -233,7 +233,7 @@ export const InnerWorkspacePanel = React.memo(function InnerWorkspacePanel({
     }
   }, [suggestionForDraggedField, expressionExists, dispatch]);
 
-  const renderEmptyWorkspace = useCallback(() => {
+  const renderEmptyWorkspace = () => {
     return (
       <EuiText
         className={classNames('lnsWorkspacePanel__emptyContent')}
@@ -278,9 +278,9 @@ export const InnerWorkspacePanel = React.memo(function InnerWorkspacePanel({
         )}
       </EuiText>
     );
-  }, [expressionExists]);
+  };
 
-  const renderVisualization = useCallback(() => {
+  const renderVisualization = () => {
     // we don't want to render the emptyWorkspace on visualizing field from Discover
     // as it is specific for the drag and drop functionality and can confuse the users
     if (expression === null && !visualizeTriggerFieldContext) {
@@ -298,19 +298,7 @@ export const InnerWorkspacePanel = React.memo(function InnerWorkspacePanel({
         ExpressionRendererComponent={ExpressionRendererComponent}
       />
     );
-  }, [
-    expression,
-    visualizeTriggerFieldContext,
-    framePublicAPI,
-    plugins.data.query.timefilter.timefilter,
-    dispatch,
-    onEvent,
-    setLocalState,
-    localState,
-    ExpressionRendererComponent,
-    configurationValidationError,
-    renderEmptyWorkspace,
-  ]);
+  };
 
   return (
     <WorkspacePanelWrapper