-
Notifications
You must be signed in to change notification settings - Fork 8.2k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[VisTypePie] Use a different advanced setting for pie charts (#103049)
* Different switch for pie * Remove unused translations Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
- Loading branch information
1 parent
507ab0e
commit 1d2ceba
Showing
28 changed files
with
183 additions
and
42 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,10 @@ | ||
/* | ||
* Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one | ||
* or more contributor license agreements. Licensed under the Elastic License | ||
* 2.0 and the Server Side Public License, v 1; you may not use this file except | ||
* in compliance with, at your election, the Elastic License 2.0 or the Server | ||
* Side Public License, v 1. | ||
*/ | ||
import { VisTypePieServerPlugin } from './plugin'; | ||
|
||
export const plugin = () => new VisTypePieServerPlugin(); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,56 @@ | ||
/* | ||
* Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one | ||
* or more contributor license agreements. Licensed under the Elastic License | ||
* 2.0 and the Server Side Public License, v 1; you may not use this file except | ||
* in compliance with, at your election, the Elastic License 2.0 or the Server | ||
* Side Public License, v 1. | ||
*/ | ||
|
||
import { i18n } from '@kbn/i18n'; | ||
import { schema } from '@kbn/config-schema'; | ||
|
||
import { CoreSetup, Plugin, UiSettingsParams } from 'kibana/server'; | ||
|
||
import { LEGACY_PIE_CHARTS_LIBRARY } from '../common'; | ||
|
||
export const getUiSettingsConfig: () => Record<string, UiSettingsParams<boolean>> = () => ({ | ||
// TODO: Remove this when vis_type_vislib is removed | ||
// https://github.com/elastic/kibana/issues/56143 | ||
[LEGACY_PIE_CHARTS_LIBRARY]: { | ||
name: i18n.translate('visTypePie.advancedSettings.visualization.legacyPieChartsLibrary.name', { | ||
defaultMessage: 'Pie legacy charts library', | ||
}), | ||
requiresPageReload: true, | ||
value: false, | ||
description: i18n.translate( | ||
'visTypePie.advancedSettings.visualization.legacyPieChartsLibrary.description', | ||
{ | ||
defaultMessage: 'Enables legacy charts library for pie charts in visualize.', | ||
} | ||
), | ||
deprecation: { | ||
message: i18n.translate( | ||
'visTypePie.advancedSettings.visualization.legacyPieChartsLibrary.deprecation', | ||
{ | ||
defaultMessage: | ||
'The legacy charts library for pie in visualize is deprecated and will not be supported as of 8.0.', | ||
} | ||
), | ||
docLinksKey: 'visualizationSettings', | ||
}, | ||
category: ['visualization'], | ||
schema: schema.boolean(), | ||
}, | ||
}); | ||
|
||
export class VisTypePieServerPlugin implements Plugin<object, object> { | ||
public setup(core: CoreSetup) { | ||
core.uiSettings.register(getUiSettingsConfig()); | ||
|
||
return {}; | ||
} | ||
|
||
public start() { | ||
return {}; | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,10 @@ | ||
/* | ||
* Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one | ||
* or more contributor license agreements. Licensed under the Elastic License | ||
* 2.0 and the Server Side Public License, v 1; you may not use this file except | ||
* in compliance with, at your election, the Elastic License 2.0 or the Server | ||
* Side Public License, v 1. | ||
*/ | ||
import { VisTypeXyServerPlugin } from './plugin'; | ||
|
||
export const plugin = () => new VisTypeXyServerPlugin(); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,56 @@ | ||
/* | ||
* Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one | ||
* or more contributor license agreements. Licensed under the Elastic License | ||
* 2.0 and the Server Side Public License, v 1; you may not use this file except | ||
* in compliance with, at your election, the Elastic License 2.0 or the Server | ||
* Side Public License, v 1. | ||
*/ | ||
|
||
import { i18n } from '@kbn/i18n'; | ||
import { schema } from '@kbn/config-schema'; | ||
|
||
import { CoreSetup, Plugin, UiSettingsParams } from 'kibana/server'; | ||
|
||
import { LEGACY_CHARTS_LIBRARY } from '../common'; | ||
|
||
export const getUiSettingsConfig: () => Record<string, UiSettingsParams<boolean>> = () => ({ | ||
// TODO: Remove this when vis_type_vislib is removed | ||
// https://github.com/elastic/kibana/issues/56143 | ||
[LEGACY_CHARTS_LIBRARY]: { | ||
name: i18n.translate('visTypeXy.advancedSettings.visualization.legacyChartsLibrary.name', { | ||
defaultMessage: 'XY axis legacy charts library', | ||
}), | ||
requiresPageReload: true, | ||
value: false, | ||
description: i18n.translate( | ||
'visTypeXy.advancedSettings.visualization.legacyChartsLibrary.description', | ||
{ | ||
defaultMessage: 'Enables legacy charts library for area, line and bar charts in visualize.', | ||
} | ||
), | ||
deprecation: { | ||
message: i18n.translate( | ||
'visTypeXy.advancedSettings.visualization.legacyChartsLibrary.deprecation', | ||
{ | ||
defaultMessage: | ||
'The legacy charts library for area, line and bar charts in visualize is deprecated and will not be supported as of 7.16.', | ||
} | ||
), | ||
docLinksKey: 'visualizationSettings', | ||
}, | ||
category: ['visualization'], | ||
schema: schema.boolean(), | ||
}, | ||
}); | ||
|
||
export class VisTypeXyServerPlugin implements Plugin<object, object> { | ||
public setup(core: CoreSetup) { | ||
core.uiSettings.register(getUiSettingsConfig()); | ||
|
||
return {}; | ||
} | ||
|
||
public start() { | ||
return {}; | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.