[VisTypePie] Use a different advanced setting for pie charts #103049
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stratoula
changed the title
stratoula
added
Feature:Pie Chart
|
Pinging @elastic/kibana-app (Team:KibanaApp) |
mshustov
approved these changes
Jun 23, 2021
poffdeluxe
approved these changes
Jun 23, 2021
|
@elasticmachine merge upstream |
flash1293
approved these changes
Jun 24, 2021
💚 Build Succeeded
Metrics [docs]Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: |
stratoula
added a commit
to stratoula/kibana
that referenced
this pull request
Jun 24, 2021
…#103049) * Different switch for pie * Remove unused translations Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
stratoula
added a commit
that referenced
this pull request
Jun 24, 2021
#103222) * Different switch for pie * Remove unused translations Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a separate advanced setting for the pie charts legacy library. Until now they had the same switch but this causes some problems with our
Make it minorinitiative.Our plan is to remove the legacy charts incrementally. So, when the new XY charts are stable, we want to remove the legacy XY charts and the switch (but the pie chart will still have both implementations) etc.
Checklist
Delete any items that are not applicable to this PR.