Add repositionOnScroll to popovers within the Inspector and the Index…

… Management detail panel. (#23856)
elastic · Oct 24, 2018 · 1db0755 · 1db0755
1 parent 2c7caee
commit 1db0755
Show file tree

Hide file tree

Showing 6 changed files with 5 additions and 1 deletion.
diff --git a/src/core_plugins/inspector_views/public/data/download_options.js b/src/core_plugins/inspector_views/public/data/download_options.js
@@ -106,6 +106,7 @@ class DataDownloadOptions extends Component {
         isOpen={this.state.isPopoverOpen}
         closePopover={this.closePopover}
         panelPaddingSize="none"
+        repositionOnScroll
       >
         <EuiContextMenuPanel
           className="eui-textNoWrap"

diff --git a/src/core_plugins/inspector_views/public/requests/request_selector.js b/src/core_plugins/inspector_views/public/requests/request_selector.js
@@ -102,6 +102,7 @@ class RequestSelector extends Component {
         closePopover={this.closePopover}
         panelPaddingSize="none"
         anchorPosition="downLeft"
+        repositionOnScroll
       >
         <EuiContextMenuPanel
           className="insRequestSelector__menuPanel"

diff --git a/src/ui/public/inspector/ui/__snapshots__/inspector_panel.test.js.snap b/src/ui/public/inspector/ui/__snapshots__/inspector_panel.test.js.snap
@@ -130,6 +130,7 @@ exports[`InspectorPanel should render as expected 1`] = `
                   isOpen={false}
                   ownFocus={true}
                   panelPaddingSize="none"
+                  repositionOnScroll={true}
                 >
                   <EuiOutsideClickDetector
                     onOutsideClick={[Function]}

diff --git a/src/ui/public/inspector/ui/inspector_panel.js b/src/ui/public/inspector/ui/inspector_panel.js
@@ -40,7 +40,6 @@ class InspectorPanel extends Component {
   constructor(props) {
     super(props);
     this.state = {
-      isHelpPopoverOpen: false,
       selectedView: props.views[0],
       views: props.views,
       // Clone adapters array so we can validate that this prop never change

diff --git a/src/ui/public/inspector/ui/inspector_view_chooser.js b/src/ui/public/inspector/ui/inspector_view_chooser.js
@@ -106,6 +106,7 @@ class InspectorViewChooser extends Component {
         closePopover={this.closeSelector}
         panelPaddingSize="none"
         anchorPosition="downRight"
+        repositionOnScroll
       >
         <EuiContextMenuPanel
           items={views.map(this.renderView)}

diff --git a/...c/sections/index_list/components/index_actions_context_menu/index_actions_context_menu.js b/...c/sections/index_list/components/index_actions_context_menu/index_actions_context_menu.js
@@ -459,6 +459,7 @@ class IndexActionsContextMenuUi extends Component {
           panelPaddingSize="none"
           withTitle
           anchorPosition={anchorPosition}
+          repositionOnScroll
         >
           <EuiContextMenu initialPanelId={0} panels={panels} />
         </EuiPopover>