Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add repositionOnScroll to popovers within the Inspector and the Index Management detail panel. #23856

Merged
merged 3 commits into from
Oct 24, 2018

Conversation

cjcenizal
Copy link
Contributor

repositionOnScroll address issues like this one:

pagination_popover_scroll

With this prop applied, the affected popovers will stick to the buttons from which they originate, when they're open and the user scrolls.

@cjcenizal cjcenizal added bug Fixes for quality problems that affect the customer experience :Management v7.0.0 v6.5.0 Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Oct 4, 2018
@cjcenizal
Copy link
Contributor Author

Relates to #23851 and #23850

@elasticmachine
Copy link
Contributor

💔 Build Failed

Copy link
Contributor

@bmcconaghy bmcconaghy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM and fixes the issue shown in the PR description.

@elasticmachine
Copy link
Contributor

💔 Build Failed

@cjcenizal
Copy link
Contributor Author

Jenkins test this

@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Team:Visualizations Visualization editors, elastic-charts and infrastructure v6.5.0 v7.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants