[Maps] fix custom icon palettes UI not being displayed (#71482)

* [Maps] fix custom icon palettes UI not being displayed

* cleanup test

* remove uneeded change to vector style defaults

* fix jest tests

* review feedback

* fix jest tests

x-pack/plugins/maps/common/descriptor_types/style_property_descriptor_types.ts

@@ -95,7 +95,7 @@ export type ColorStylePropertyDescriptor =
   | ColorDynamicStylePropertyDescriptor;
 
 export type IconDynamicOptions = {
-  iconPaletteId?: string;
+  iconPaletteId: string | null;
   customIconStops?: IconStop[];
   useCustomIconMap?: boolean;
   field?: StylePropertyField;

x-pack/plugins/maps/public/classes/layers/solution_layers/observability/create_layer_descriptor.test.ts

@@ -5,14 +5,9 @@
  */
 
 jest.mock('../../../../kibana_services', () => {
-  const mockUiSettings = {
-    get: () => {
-      return undefined;
-    },
-  };
   return {
-    getUiSettings: () => {
-      return mockUiSettings;
+    getIsDarkMode() {
+      return false;
     },
   };
 });

x-pack/plugins/maps/public/classes/layers/solution_layers/security/create_layer_descriptors.test.ts

@@ -5,14 +5,9 @@
  */
 
 jest.mock('../../../../kibana_services', () => {
-  const mockUiSettings = {
-    get: () => {
-      return undefined;
-    },
-  };
   return {
-    getUiSettings: () => {
-      return mockUiSettings;
+    getIsDarkMode() {
+      return false;
     },
   };
 });

x-pack/plugins/maps/public/classes/layers/tiled_vector_layer/tiled_vector_layer.test.tsx

@@ -8,12 +8,8 @@ import sinon from 'sinon';
 
 jest.mock('../../../kibana_services', () => {
   return {
-    getUiSettings() {
-      return {
-        get() {
-          return false;
-        },
-      };
+    getIsDarkMode() {
+      return false;
     },
   };
 });

x-pack/plugins/maps/public/classes/sources/ems_tms_source/ems_tms_source.js

@@ -12,7 +12,7 @@ import { UpdateSourceEditor } from './update_source_editor';
 import { i18n } from '@kbn/i18n';
 import { getDataSourceLabel } from '../../../../common/i18n_getters';
 import { SOURCE_TYPES } from '../../../../common/constants';
-import { getEmsTileLayerId, getUiSettings } from '../../../kibana_services';
+import { getEmsTileLayerId, getIsDarkMode } from '../../../kibana_services';
 import { registerSource } from '../source_registry';
 
 export const sourceTitle = i18n.translate('xpack.maps.source.emsTileTitle', {
@@ -122,9 +122,8 @@ export class EMSTMSSource extends AbstractTMSSource {
       return this._descriptor.id;
     }
 
-    const isDarkMode = getUiSettings().get('theme:darkMode', false);
     const emsTileLayerId = getEmsTileLayerId();
-    return isDarkMode ? emsTileLayerId.dark : emsTileLayerId.bright;
+    return getIsDarkMode() ? emsTileLayerId.dark : emsTileLayerId.bright;
   }
 }
 

x-pack/plugins/maps/public/classes/styles/vector/components/symbol/dynamic_icon_form.js

@@ -12,11 +12,9 @@ import { IconMapSelect } from './icon_map_select';
 
 export function DynamicIconForm({
   fields,
-  isDarkMode,
   onDynamicStyleChange,
   staticDynamicSelect,
   styleProperty,
-  symbolOptions,
 }) {
   const styleOptions = styleProperty.getOptions();
 
@@ -44,11 +42,8 @@ export function DynamicIconForm({
     return (
       <IconMapSelect
         {...styleOptions}
-        useCustomIconMap={_.get(styleOptions, 'useCustomColorRamp', false)}
         styleProperty={styleProperty}
         onChange={onIconMapChange}
-        isDarkMode={isDarkMode}
-        symbolOptions={symbolOptions}
         isCustomOnly={!field.supportsAutoDomain()}
       />
     );