Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Maps] fix custom icon palettes UI not being displayed #71482

Merged
merged 7 commits into from
Jul 14, 2020
Merged

[Maps] fix custom icon palettes UI not being displayed #71482

merged 7 commits into from
Jul 14, 2020

Conversation

nreese
Copy link
Contributor

@nreese nreese commented Jul 13, 2020

Fixes #71263

@nreese nreese added [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.9.0 labels Jul 13, 2020
@nreese nreese requested a review from kindsun July 13, 2020 16:41
@nreese nreese requested a review from a team as a code owner July 13, 2020 16:41
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-gis (Team:Geo)

@kindsun
Copy link
Contributor

kindsun commented Jul 14, 2020 •
edited
Loading

When applying icons to any of the sample datasets, I'm getting what appears to be a combination of several icons applied to points on the map:

image

Cancel that, multiple points on each location. That is a rough user experience though...

@thomasneirynck
Copy link
Contributor

That is a rough user experience though...

another argument for #70131

thomasneirynck
thomasneirynck approved these changes Jul 14, 2020
View reviewed changes
Copy link
Contributor

@thomasneirynck thomasneirynck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested in chrome. works. thx for TS-conversion.

x-pack/plugins/maps/public/classes/styles/vector/components/symbol/icon_select.js Outdated Show resolved Hide resolved
kindsun
kindsun approved these changes Jul 14, 2020
View reviewed changes
Copy link
Contributor

@kindsun kindsun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! Some minor comments

  • code review
  • tested locally in chrome

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@nreese nreese merged commit 34c54ed into elastic:master Jul 14, 2020
nreese added a commit to nreese/kibana that referenced this pull request Jul 14, 2020
@nreese
[Maps] fix custom icon palettes UI not being displayed (elastic#71482)
88be230 
* [Maps] fix custom icon palettes UI not being displayed

* cleanup test

* remove uneeded change to vector style defaults

* fix jest tests

* review feedback

* fix jest tests
@nreese nreese mentioned this pull request Jul 14, 2020
Merged
nreese added a commit that referenced this pull request Jul 14, 2020
@nreese
[Maps] fix custom icon palettes UI not being displayed (#71482) (#71767)
6cec3df 
* [Maps] fix custom icon palettes UI not being displayed

* cleanup test

* remove uneeded change to vector style defaults

* fix jest tests

* review feedback

* fix jest tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kindsun kindsun kindsun approved these changes

@thomasneirynck thomasneirynck thomasneirynck approved these changes

Assignees
No one assigned
Labels
[Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation release_note:skip Skip the PR/issue when compiling release notes v7.9.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Maps] Custom icon palettes are broken
5 participants
@nreese @elasticmachine @kindsun @thomasneirynck @kibanamachine