Skip to content

Commit

Permalink
[Dashboard] Remove Legacy Dashboard Only Mode (#108103)
Browse files Browse the repository at this point in the history
Remove all dashboard only mode code and tests. Align dashboard permissions to use showWriteControls only
  • Loading branch information
ThomThomson authored Aug 20, 2021
1 parent 92ec225 commit 95463f4
Show file tree
Hide file tree
Showing 57 changed files with 101 additions and 1,497 deletions.
1 change: 0 additions & 1 deletion .github/CODEOWNERS
Validating CODEOWNERS rules …
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,6 @@
/x-pack/plugins/dashboard_enhanced/ @elastic/kibana-presentation
/x-pack/test/functional/apps/canvas/ @elastic/kibana-presentation
#CC# /src/plugins/kibana_react/public/code_editor/ @elastic/kibana-presentation
#CC# /x-pack/plugins/dashboard_mode @elastic/kibana-presentation

# Machine Learning
/x-pack/plugins/ml/ @elastic/ml-ui
Expand Down
238 changes: 0 additions & 238 deletions api_docs/dashboard_mode.json

This file was deleted.

32 changes: 0 additions & 32 deletions api_docs/dashboard_mode.mdx

This file was deleted.

4 changes: 0 additions & 4 deletions docs/developer/plugin-list.asciidoc
Original file line number Diff line number Diff line change
Expand Up @@ -378,10 +378,6 @@ The client-side plugin configures following values:
|Adds drilldown capabilities to dashboard. Owned by the Kibana App team.
|{kib-repo}blob/{branch}/x-pack/plugins/dashboard_mode/README.md[dashboardMode]
|The deprecated dashboard only mode.
|{kib-repo}blob/{branch}/x-pack/plugins/data_enhanced/README.md[dataEnhanced]
|The data_enhanced plugin is the x-pack counterpart to the src/plguins/data plugin.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,5 +22,4 @@ export interface ChromeNavLinks
| [getForceAppSwitcherNavigation$()](./kibana-plugin-core-public.chromenavlinks.getforceappswitchernavigation_.md) | An observable of the forced app switcher state. |
| [getNavLinks$()](./kibana-plugin-core-public.chromenavlinks.getnavlinks_.md) | Get an observable for a sorted list of navlinks. |
| [has(id)](./kibana-plugin-core-public.chromenavlinks.has.md) | Check whether or not a navlink exists. |
| [showOnly(id)](./kibana-plugin-core-public.chromenavlinks.showonly.md) | Remove all navlinks except the one matching the given id. |

This file was deleted.

1 change: 0 additions & 1 deletion packages/kbn-optimizer/limits.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@ pageLoadAssetSize:
crossClusterReplication: 65408
dashboard: 374194
dashboardEnhanced: 65646
dashboardMode: 22716
data: 824229
dataEnhanced: 50420
devTools: 38637
Expand Down
1 change: 0 additions & 1 deletion src/core/public/chrome/chrome_service.mock.ts
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@ const createStartContractMock = () => {
has: jest.fn(),
get: jest.fn(),
getAll: jest.fn(),
showOnly: jest.fn(),
enableForcedAppSwitcherNavigation: jest.fn(),
getForceAppSwitcherNavigation$: jest.fn(),
},
Expand Down
Loading

0 comments on commit 95463f4

Please sign in to comment.