Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Dashboard] Remove Legacy Dashboard Only Mode #108103

Merged
merged 17 commits into from
Aug 20, 2021
Merged

[Dashboard] Remove Legacy Dashboard Only Mode #108103

merged 17 commits into from
Aug 20, 2021

Conversation

ThomThomson
Copy link
Contributor

@ThomThomson ThomThomson commented Aug 10, 2021 •
edited
Loading

Summary

Fixes #67617

This PR completely removes the dashboard mode plugin and functional tests. It also:

  • removes dashboardConfig from kibana_legacy
  • aligns the dashboard app writeControls logic around the showWriteControls permission from the capabilities service.
  • Removes the showOnly method from nav_links_service

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@ThomThomson ThomThomson added Feature:Dashboard Dashboard related features release_note:breaking Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas v8.0.0 impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. loe:small Small Level of Effort labels Aug 10, 2021
@kibanamachine
Copy link
Contributor

kibanamachine commented Aug 10, 2021 •
edited
Loading

⏳ Build in-progress, with failures

Failed CI Steps

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@ThomThomson ThomThomson mentioned this pull request Aug 13, 2021
Closed
4 tasks
@ThomThomson ThomThomson marked this pull request as ready for review August 18, 2021 14:13
@ThomThomson ThomThomson requested a review from a team as a code owner August 18, 2021 14:13
@ThomThomson ThomThomson requested a review from a team August 18, 2021 14:13
@ThomThomson ThomThomson requested review from a team as code owners August 18, 2021 14:13
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

jbudz
jbudz approved these changes Aug 18, 2021
View reviewed changes
Copy link
Member

@jbudz jbudz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

limits.yml LGTM

jportner
jportner reviewed Aug 19, 2021
View reviewed changes
tsconfig.refs.json Outdated
@@ -0,0 +1,125 @@
{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like this file may have been accidentally included in this PR?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh, not sure where that came from, or why the .GITIGNORE didn't catch it. I have removed it though.

@jportner jportner mentioned this pull request Aug 19, 2021
Closed
poffdeluxe
poffdeluxe approved these changes Aug 19, 2021
View reviewed changes
Copy link
Contributor

@poffdeluxe poffdeluxe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ThomThomson
Copy link
Contributor Author

@elasticmachine merge upstream

timroes
timroes approved these changes Aug 20, 2021
View reviewed changes
Copy link
Contributor

@timroes timroes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed code changes for Kibana App only. LGTM

@jportner jportner mentioned this pull request Aug 20, 2021
Closed
@jportner
Copy link
Contributor

jportner commented Aug 20, 2021 •
edited
Loading

@ThomThomson the test that you fixed has been skipped in #109343,

kibana/x-pack/test/functional/apps/security/users.js

Lines 15 to 16 in 0f75573

// FAILING ES PROMOTION: https://github.com/elastic/kibana/issues/109349
describe.skip('users', function () {

Would you mind tweaking this PR to unskip the test?

Edit: nevermind, @azasypkin has converted the test to TS and unskipped it in #109422. You might have to deal with a minor merge conflict though 🙈

@ThomThomson
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
dashboardMode 4 - -4
kibanaLegacy 59 58 -1
total -5

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
dashboard 221.4KB 221.5KB +36.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
core 423.6KB 423.1KB -459.0B
dashboard 329.2KB 329.2KB +12.0B
dashboardMode 4.3KB - -4.3KB
discoverEnhanced 8.9KB 8.6KB -214.0B
kibanaLegacy 46.2KB 45.9KB -279.0B
total -5.2KB
Unknown metric groups

API count

id before after diff
core 2246 2244 -2
dashboardMode 11 - -11
total -13

API count missing comments

id before after diff
core 998 997 -1
dashboardMode 11 - -11
total -12

Non-exported public API item count

id before after diff
kibanaLegacy 1 0 -1

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@ThomThomson ThomThomson merged commit 95463f4 into elastic:master Aug 20, 2021
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 108103 or prevent reminders by adding the backport:skip label.

@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Aug 24, 2021
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 108103 or prevent reminders by adding the backport:skip label.

@jportner jportner added the backport:skip This commit does not require backporting label Aug 25, 2021
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Aug 25, 2021
@jportner jportner mentioned this pull request Sep 3, 2021
Closed
@ThomThomson ThomThomson mentioned this pull request Oct 29, 2021
Closed
@ThomThomson ThomThomson mentioned this pull request Jan 14, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jportner jportner jportner left review comments

@thomheymann thomheymann thomheymann approved these changes

@poffdeluxe poffdeluxe poffdeluxe approved these changes

@timroes timroes timroes approved these changes

@jbudz jbudz jbudz approved these changes

@mshustov mshustov mshustov approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting Feature:Dashboard Dashboard related features impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. loe:small Small Level of Effort release_note:breaking Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove the dashboard only mode
9 participants
@ThomThomson @kibanamachine @elasticmachine @jportner @thomheymann @poffdeluxe @timroes @jbudz @mshustov