Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove dashbord_only_user role asserting from the reserved roles test. #109422

Merged
merged 1 commit into from
Aug 20, 2021
Merged

Remove dashbord_only_user role asserting from the reserved roles test. #109422

merged 1 commit into from
Aug 20, 2021

Conversation

azasypkin
Copy link
Member

Summary

Remove dashbord_only_user role asserting from the reserved roles test.

Fixes: #109349

@azasypkin azasypkin added Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more! failed-test A test failure on a tracked branch, potentially flaky-test v8.0.0 release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting labels Aug 20, 2021
@azasypkin azasypkin mentioned this pull request Aug 20, 2021
Closed
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@azasypkin azasypkin marked this pull request as ready for review August 20, 2021 14:03
@azasypkin azasypkin requested a review from a team as a code owner August 20, 2021 14:03
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-security (Team:Security)

@jportner jportner mentioned this pull request Aug 20, 2021
Merged
2 tasks
jportner
jportner approved these changes Aug 20, 2021
View reviewed changes
Copy link
Contributor

@jportner jportner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@azasypkin azasypkin merged commit 0e39eeb into elastic:master Aug 20, 2021
@azasypkin azasypkin deleted the issue-109349-re-enable-user-tests branch August 20, 2021 14:07
@azasypkin azasypkin mentioned this pull request Jan 17, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jportner jportner jportner approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting failed-test A test failure on a tracked branch, potentially flaky-test release_note:skip Skip the PR/issue when compiling release notes Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more! v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Failing ES Promotion: security app users should show the default roles
4 participants
@azasypkin @kibanamachine @elasticmachine @jportner